[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 04/19] accel/tcg: Adjust probe_access call to page_check_r
From: |
Peter Maydell |
Subject: |
Re: [PATCH v5 04/19] accel/tcg: Adjust probe_access call to page_check_range |
Date: |
Mon, 11 May 2020 11:19:39 +0100 |
On Fri, 8 May 2020 at 17:57, Richard Henderson
<address@hidden> wrote:
> On 5/8/20 9:13 AM, Peter Maydell wrote:
> > We've gone round this multiple times now so I feel like
> > I must be missing something here.
>
> While probe_access() has a size parameter, probe_access_flags() does not.
>
> For probe_access_internal(), I currently have a "fault_size" parameter that
> gets passed to tlb_fill, which is "size" for probe_access() and 0 for
> probe_access_flags().
>
> I *could* add another "check_size" parameter to probe_access_internal, to be
> passed on to page_check_range(). It would be "size" for probe_access() and 1
> for probe_access_flags(). But what's the point? Always passing 1 to
> page_check_range() has the same effect.
>
> I feel like I'm missing something with your objection.
The thing I was missing was that probe_access_flags() doesn't
have a size to pass usefully to probe_access_internal() and
so the size is zero in that case, but that tlb_fill() and
probe_check_range() want different values for the "just
tell me about this address" case.
thanks
-- PMM
- [PATCH v5 00/19] target/arm: sve load/store improvements, Richard Henderson, 2020/05/08
- [PATCH v5 05/19] accel/tcg: Add probe_access_flags, Richard Henderson, 2020/05/08
- [PATCH v5 07/19] target/arm: Use cpu_*_data_ra for sve_ldst_tlb_fn, Richard Henderson, 2020/05/08
- [PATCH v5 08/19] target/arm: Drop manual handling of set/clear_helper_retaddr, Richard Henderson, 2020/05/08
- [PATCH v5 11/19] target/arm: Use SVEContLdSt in sve_ld1_r, Richard Henderson, 2020/05/08
- [PATCH v5 06/19] accel/tcg: Add endian-specific cpu_{ld, st}* operations, Richard Henderson, 2020/05/08
- [PATCH v5 09/19] target/arm: Add sve infrastructure for page lookup, Richard Henderson, 2020/05/08
- [PATCH v5 12/19] target/arm: Handle watchpoints in sve_ld1_r, Richard Henderson, 2020/05/08
- [PATCH v5 10/19] target/arm: Adjust interface of sve_ld1_host_fn, Richard Henderson, 2020/05/08
- [PATCH v5 14/19] target/arm: Update contiguous first-fault and no-fault loads, Richard Henderson, 2020/05/08
- [PATCH v5 15/19] target/arm: Use SVEContLdSt for contiguous stores, Richard Henderson, 2020/05/08