Re: [PATCH v8] audio/jack: add JACK client audiodev

[Eric Blake]

On 4/29/20 12:53 AM, Geoffrey McRae wrote:
> This commit adds a new audiodev backend to allow QEMU to use JACK as
> both an audio sink and source.
>
> Signed-off-by: Geoffrey McRae <address@hidden>
> ---

> +++ b/qapi/audio.json
> @@ -152,6 +152,55 @@
>       '*out':     'AudiodevPerDirectionOptions',
>       '*latency': 'uint32' } }
>   
> +##
> +# @AudiodevJackPerDirectionOptions:
> +#
> +# Options of the JACK backend that are used for both playback and
> +# recording.
> +#
> +# @server-name: select from among several possible concurrent server instances
> +# (default: environment variable $JACK_DEFAULT_SERVER if set, else "default")
> +#
> +# @client-name: the client name to use. The server will modify this name to
> +# create a unique variant, if needed unless @exact_name is true (default: the

Minor typos: @exact_name does not match...

> +# guest's name)
> +#
> +# @connect-ports: if set, a regular expression of JACK client port name(s) to
> +# monitor for and automatically connect to
> +#
> +# @start-server: start a jack server process if one is not lready present

already

> +# (default: false)
> +#
> +# @exact-name: use the exact name requested otherwise JACK automatically
> +# generates a unique one, if needed (default: false)

...the actual parameter @exact-name.

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org