Re: [PATCH v1 0/8] plugins/next (cleanup, cpu_index and lockstep)

[Philippe Mathieu-Daudé]

On 5/13/20 7:31 PM, Alex Bennée wrote:
> Hi,
>
> This is the current state of my plugins/next tree. It contains 3 bits
> of work.
>
> First some minor clean-ups from Phillipe to help with his other
> re-factoring work.

Thanks for picking these. Note they already have:
Reviewed-by: Emilio G. Cota <address@hidden>
https://www.mail-archive.com/address@hidden/msg701882.html

> Next are some fixes for a crash reported by Nikolay on the list. The
> root cause was a re-use of cpu_index although I've also tried to clean
> up the handling of pthread termination.
>
> Finally there is another iteration of my lockstep plugin which has had
> a little more tinkering to better detect divergence between two
> QEMU's. It's no Rehoboam but it will hopefully be helpful.
>
> The following patches need review:
>
>   - plugins: new lockstep plugin for debugging TCG changes
>   - tests/tcg: add new threadcount test
>   - linux-user: properly "unrealize" vCPU object
>   - cpus-common: ensure auto-assigned cpu_indexes don't clash
>   - MAINTAINERS: update the orphaned cpus-common.c file
>
> Alex Bennée (5):
>    MAINTAINERS: update the orphaned cpus-common.c file
>    cpus-common: ensure auto-assigned cpu_indexes don't clash
>    linux-user: properly "unrealize" vCPU object
>    tests/tcg: add new threadcount test
>    plugins: new lockstep plugin for debugging TCG changes
>
> Philippe Mathieu-Daudé (3):
>    qemu/plugin: Trivial code movement
>    qemu/plugin: Move !CONFIG_PLUGIN stubs altogether
>    qemu/qemu-plugin: Make qemu_plugin_hwaddr_is_io() hwaddr argument
>      const
>
>   include/qemu/plugin.h               |  65 +++---
>   include/qemu/qemu-plugin.h          |   2 +-
>   cpus-common.c                       |   9 +-
>   linux-user/syscall.c                |  19 +-
>   plugins/api.c                       |   4 +-
>   tests/plugin/lockstep.c             | 345 ++++++++++++++++++++++++++++
>   tests/tcg/multiarch/threadcount.c   |  62 +++++
>   MAINTAINERS                         |   1 +
>   tests/plugin/Makefile               |   1 +
>   tests/tcg/Makefile.target           |   2 +-
>   tests/tcg/multiarch/Makefile.target |   2 +
>   11 files changed, 461 insertions(+), 51 deletions(-)
>   create mode 100644 tests/plugin/lockstep.c
>   create mode 100644 tests/tcg/multiarch/threadcount.c