[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 4/6] tests/fuzz: Remove unuseful/unused typedefs
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH 4/6] tests/fuzz: Remove unuseful/unused typedefs |
Date: |
Thu, 14 May 2020 16:34:31 +0200 |
These typedefs are not used. Use a simple structure,
remote the typedefs.
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
---
tests/qtest/fuzz/i440fx_fuzz.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/tests/qtest/fuzz/i440fx_fuzz.c b/tests/qtest/fuzz/i440fx_fuzz.c
index 96fed9ff12..c197b026db 100644
--- a/tests/qtest/fuzz/i440fx_fuzz.c
+++ b/tests/qtest/fuzz/i440fx_fuzz.c
@@ -45,12 +45,11 @@ static void i440fx_fuzz_qtest(QTestState *s,
* loop over the Data, breaking it up into actions. each action has an
* opcode, address offset and value
*/
- typedef struct QTestFuzzAction {
+ struct {
uint8_t opcode;
uint8_t addr;
uint32_t value;
- } QTestFuzzAction;
- QTestFuzzAction a;
+ } a;
while (Size >= sizeof(a)) {
/* make a copy of the action so we can normalize the values in-place */
@@ -91,19 +90,18 @@ static void i440fx_fuzz_qos(QTestState *s,
* Same as i440fx_fuzz_qtest, but using QOS. devfn is incorporated into the
* value written over Port IO
*/
- typedef struct QOSFuzzAction {
+ struct {
uint8_t opcode;
uint8_t offset;
int devfn;
uint32_t value;
- } QOSFuzzAction;
+ } a;
static QPCIBus *bus;
if (!bus) {
bus = qpci_new_pc(s, fuzz_qos_alloc);
}
- QOSFuzzAction a;
while (Size >= sizeof(a)) {
memcpy(&a, Data, sizeof(a));
switch (a.opcode % ACTION_MAX) {
--
2.21.3
- [PATCH 0/6] tests/fuzz: Review notes, Philippe Mathieu-Daudé, 2020/05/14
- [PATCH 1/6] tests/fuzz/Makefile: Do not link code using unavailable devices, Philippe Mathieu-Daudé, 2020/05/14
- [PATCH 2/6] Makefile: List fuzz targets in 'make help', Philippe Mathieu-Daudé, 2020/05/14
- [PATCH 3/6] tests/fuzz: Add missing space in test description, Philippe Mathieu-Daudé, 2020/05/14
- [PATCH 4/6] tests/fuzz: Remove unuseful/unused typedefs,
Philippe Mathieu-Daudé <=
- [PATCH 5/6] tests/fuzz: Extract pciconfig_fuzz_qos() method, Philippe Mathieu-Daudé, 2020/05/14
- [PATCH 6/6] tests/fuzz: Extract ioport_fuzz_qtest() method, Philippe Mathieu-Daudé, 2020/05/14
- Re: [PATCH 0/6] tests/fuzz: Review notes, Stefan Hajnoczi, 2020/05/15
- Re: [PATCH 0/6] tests/fuzz: Review notes, Alexander Bulekov, 2020/05/15