[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] 9pfs: fix init_in_iov_from_pdu truncating size
From: |
Stefano Stabellini |
Subject: |
Re: [PATCH 2/2] 9pfs: fix init_in_iov_from_pdu truncating size |
Date: |
Thu, 14 May 2020 08:51:27 -0700 (PDT) |
User-agent: |
Alpine 2.21 (DEB 202 2017-01-01) |
On Thu, 14 May 2020, Christian Schoenebeck wrote:
> Looks like this issue will still take quite some time to be fixed with Xen.
> If
> you don't mind I'll send out a patch to revert truncation on virtio side, so
> that at least this bug is fixed with virtio ASAP.
Let me answer to this quickly so that if you want to get the patch out
today you can.
Yes, I think it is OK to revert truncation in virtio now. Only one
thing: would there still be any value in doing for Xen:
+ if (pdu->id + 1 == P9_RREAD) {
+ /* size[4] Rread tag[2] count[4] data[count] */
+ const size_t hdr_size = 11;
+ /*
+ * If current transport buffer size is smaller than actually required
+ * for this Rreaddir response, then truncate the response to the
+ * currently available transport buffer size, however only if it would
+ * at least allow to return 1 payload byte to client.
+ */
+ if (buf_size < hdr_size + 1) {
like your patch here does? Although not a complete solution it looks
like it would still be a good improvement over the current situation for
Xen.
- [PATCH 0/2] 9pfs: regression init_in_iov_from_pdu truncating size, Christian Schoenebeck, 2020/05/10
- [PATCH 2/2] 9pfs: fix init_in_iov_from_pdu truncating size, Christian Schoenebeck, 2020/05/10
- Re: [PATCH 2/2] 9pfs: fix init_in_iov_from_pdu truncating size, Christian Schoenebeck, 2020/05/10
- Re: [PATCH 2/2] 9pfs: fix init_in_iov_from_pdu truncating size, Stefano Stabellini, 2020/05/11
- Re: [PATCH 2/2] 9pfs: fix init_in_iov_from_pdu truncating size, Christian Schoenebeck, 2020/05/12
- Re: [PATCH 2/2] 9pfs: fix init_in_iov_from_pdu truncating size, Stefano Stabellini, 2020/05/12
- Re: [PATCH 2/2] 9pfs: fix init_in_iov_from_pdu truncating size, Christian Schoenebeck, 2020/05/13
- Re: [PATCH 2/2] 9pfs: fix init_in_iov_from_pdu truncating size, Stefano Stabellini, 2020/05/13
- Re: [PATCH 2/2] 9pfs: fix init_in_iov_from_pdu truncating size, Christian Schoenebeck, 2020/05/14
- Re: [PATCH 2/2] 9pfs: fix init_in_iov_from_pdu truncating size,
Stefano Stabellini <=
- Re: [PATCH 2/2] 9pfs: fix init_in_iov_from_pdu truncating size, Christian Schoenebeck, 2020/05/14
- Re: [PATCH 2/2] 9pfs: fix init_in_iov_from_pdu truncating size, Stefano Stabellini, 2020/05/14
- Re: [PATCH 2/2] 9pfs: fix init_in_iov_from_pdu truncating size, Stefano Stabellini, 2020/05/14
- Re: [PATCH 2/2] 9pfs: fix init_in_iov_from_pdu truncating size, Christian Schoenebeck, 2020/05/14
[PATCH 1/2] xen-9pfs: Fix log messages of reply errors, Christian Schoenebeck, 2020/05/10
Re: [PATCH 0/2] 9pfs: regression init_in_iov_from_pdu truncating size, Greg Kurz, 2020/05/12