Re: [PATCH 1/2] tests/docker: Remove flex/bison packages

[Claudio Fontana]

On 5/15/20 10:31 AM, Philippe Mathieu-Daudé wrote:
> QEMU does use flex/bison packages.
> 
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>

Hi Philippe, "does" or "does not"?

Ciao,

Claudio

> ---
>  tests/docker/dockerfiles/centos7.docker             | 2 --
>  tests/docker/dockerfiles/centos8.docker             | 2 --
>  tests/docker/dockerfiles/debian-xtensa-cross.docker | 2 --
>  tests/docker/dockerfiles/debian10.docker            | 2 --
>  tests/docker/dockerfiles/debian9.docker             | 2 --
>  tests/docker/dockerfiles/fedora.docker              | 2 --
>  tests/docker/dockerfiles/ubuntu.docker              | 2 +-
>  tests/docker/dockerfiles/ubuntu1804.docker          | 2 +-
>  8 files changed, 2 insertions(+), 14 deletions(-)
> 
> diff --git a/tests/docker/dockerfiles/centos7.docker 
> b/tests/docker/dockerfiles/centos7.docker
> index 9a2a2e515d..e197acdc3c 100644
> --- a/tests/docker/dockerfiles/centos7.docker
> +++ b/tests/docker/dockerfiles/centos7.docker
> @@ -5,13 +5,11 @@ RUN yum -y update
>  
>  # Please keep this list sorted alphabetically
>  ENV PACKAGES \
> -    bison \
>      bzip2 \
>      bzip2-devel \
>      ccache \
>      csnappy-devel \
>      dbus-daemon \
> -    flex \
>      gcc-c++ \
>      gcc \
>      gettext \
> diff --git a/tests/docker/dockerfiles/centos8.docker 
> b/tests/docker/dockerfiles/centos8.docker
> index bfa0d33c9c..9852c5b9ee 100644
> --- a/tests/docker/dockerfiles/centos8.docker
> +++ b/tests/docker/dockerfiles/centos8.docker
> @@ -3,11 +3,9 @@ FROM centos:8.1.1911
>  RUN dnf -y update
>  ENV PACKAGES \
>      SDL-devel \
> -    bison \
>      bzip2 \
>      bzip2-devel \
>      dbus-daemon \
> -    flex \
>      gcc \
>      gcc-c++ \
>      gettext \
> diff --git a/tests/docker/dockerfiles/debian-xtensa-cross.docker 
> b/tests/docker/dockerfiles/debian-xtensa-cross.docker
> index e6f93f65ee..beb73f46ba 100644
> --- a/tests/docker/dockerfiles/debian-xtensa-cross.docker
> +++ b/tests/docker/dockerfiles/debian-xtensa-cross.docker
> @@ -11,11 +11,9 @@ RUN apt-get update && \
>      DEBIAN_FRONTEND=noninteractive apt install -yy eatmydata && \
>      DEBIAN_FRONTEND=noninteractive eatmydata \
>      apt-get install -y --no-install-recommends \
> -        bison \
>          build-essential \
>          ca-certificates \
>          curl \
> -        flex \
>          gettext \
>          git \
>          python3-minimal
> diff --git a/tests/docker/dockerfiles/debian10.docker 
> b/tests/docker/dockerfiles/debian10.docker
> index 0769700a41..bcdff04ddf 100644
> --- a/tests/docker/dockerfiles/debian10.docker
> +++ b/tests/docker/dockerfiles/debian10.docker
> @@ -18,12 +18,10 @@ RUN apt update && \
>      DEBIAN_FRONTEND=noninteractive eatmydata \
>      apt install -y --no-install-recommends \
>          bc \
> -        bison \
>          build-essential \
>          ca-certificates \
>          clang \
>          dbus \
> -        flex \
>          gdb-multiarch \
>          gettext \
>          git \
> diff --git a/tests/docker/dockerfiles/debian9.docker 
> b/tests/docker/dockerfiles/debian9.docker
> index 08cc970feb..0f0ebe530a 100644
> --- a/tests/docker/dockerfiles/debian9.docker
> +++ b/tests/docker/dockerfiles/debian9.docker
> @@ -18,11 +18,9 @@ RUN apt update && \
>      DEBIAN_FRONTEND=noninteractive eatmydata \
>      apt install -y --no-install-recommends \
>          bc \
> -        bison \
>          build-essential \
>          ca-certificates \
>          clang \
> -        flex \
>          gdb-multiarch \
>          gettext \
>          git \
> diff --git a/tests/docker/dockerfiles/fedora.docker 
> b/tests/docker/dockerfiles/fedora.docker
> index 179575ecaa..92b6e11c8a 100644
> --- a/tests/docker/dockerfiles/fedora.docker
> +++ b/tests/docker/dockerfiles/fedora.docker
> @@ -3,7 +3,6 @@ FROM fedora:30
>  # Please keep this list sorted alphabetically
>  ENV PACKAGES \
>      bc \
> -    bison \
>      brlapi-devel \
>      bzip2 \
>      bzip2-devel \
> @@ -13,7 +12,6 @@ ENV PACKAGES \
>      dbus-daemon \
>      device-mapper-multipath-devel \
>      findutils \
> -    flex \
>      gcc \
>      gcc-c++ \
>      gettext \
> diff --git a/tests/docker/dockerfiles/ubuntu.docker 
> b/tests/docker/dockerfiles/ubuntu.docker
> index eeb3b22bf2..90ea6311c6 100644
> --- a/tests/docker/dockerfiles/ubuntu.docker
> +++ b/tests/docker/dockerfiles/ubuntu.docker
> @@ -10,7 +10,7 @@
>  #
>  
>  FROM ubuntu:19.04
> -ENV PACKAGES flex bison \
> +ENV PACKAGES \
>      ccache \
>      clang \
>      dbus \
> diff --git a/tests/docker/dockerfiles/ubuntu1804.docker 
> b/tests/docker/dockerfiles/ubuntu1804.docker
> index f66b06f4cf..a10ea2850b 100644
> --- a/tests/docker/dockerfiles/ubuntu1804.docker
> +++ b/tests/docker/dockerfiles/ubuntu1804.docker
> @@ -1,5 +1,5 @@
>  FROM ubuntu:18.04
> -ENV PACKAGES flex bison \
> +ENV PACKAGES \
>      ccache \
>      clang \
>      gcc \
>