Re: [PULL 00/21] QOM patches for 2020-05-15

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Subject: [PULL 00/21] QOM patches for 2020-05-15
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Switched to a new branch 'test'
157b9a0 hw: Remove unnecessary DEVICE() cast
9f0727a various: Remove unnecessary OBJECT() cast
285893c target: Remove unnecessary CPU() cast
4f3b6ea qom: Drop @errp parameter of object_property_del()
6b33a05 spapr_pci: Drop some dead error handling
4534b81 qdev: Unrealize must not fail
4ff5d80 Drop more @errp parameters after previous commit
5d57342 qom: Drop parameter @errp of object_property_add() & friends
8f15bf9 qdev: Clean up qdev_connect_gpio_out_named()
62ec2ad hw/arm/bcm2835: Drop futile attempts at QOM-adopting memory
d1d611d e1000: Don't run e1000_instance_init() twice
2953147 hw/isa/superio: Make the components QOM children
b751c99 s390x/cpumodel: Fix UI to CPU features pcc-cmac-{aes, eaes}-256
02d22e5 tests/check-qom-proplist: Improve iterator coverage
0dd01c70 qom: Drop object_property_set_description() parameter @errp
a67a26e qom: Make all the object_property_add_FOO() return the property
1808c8c qom: Drop convenience method object_property_get_uint16List()
2a94dbe qom: Simplify object_property_get_enum()
7bb519d qom: Drop object_property_del_child()'s unused parameter @errp
47b112a qom: Clean up inconsistent use of gchar * vs. char *
0713ea8 qom: Clearer reference counting in object_initialize_childv()

=== OUTPUT BEGIN ===
1/21 Checking commit 0713ea8ea223 (qom: Clearer reference counting in 
object_initialize_childv())
2/21 Checking commit 47b112af3d60 (qom: Clean up inconsistent use of gchar * 
vs. char *)
3/21 Checking commit 7bb519d4b3bf (qom: Drop object_property_del_child()'s 
unused parameter @errp)
4/21 Checking commit 2a94dbe12ace (qom: Simplify object_property_get_enum())
5/21 Checking commit 1808c8ca8b3c (qom: Drop convenience method 
object_property_get_uint16List())
6/21 Checking commit a67a26ef03cb (qom: Make all the object_property_add_FOO() 
return the property)
7/21 Checking commit 0dd01c703284 (qom: Drop object_property_set_description() 
parameter @errp)
8/21 Checking commit 02d22e51a839 (tests/check-qom-proplist: Improve iterator 
coverage)
9/21 Checking commit b751c99d3799 (s390x/cpumodel: Fix UI to CPU features 
pcc-cmac-{aes, eaes}-256)
ERROR: line over 90 characters
#59: FILE: target/s390x/cpu_features_def.inc.h:314:
+DEF_FEAT(PCC_CMAC_AES_256, "pcc-cmac-aes-256", PCC, 20, "PCC 
Compute-Last-Block-CMAC-Using-AES-256")

total: 1 errors, 0 warnings, 8 lines checked

Patch 9/21 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

10/21 Checking commit 29531470b836 (hw/isa/superio: Make the components QOM 
children)
11/21 Checking commit d1d611d112bc (e1000: Don't run e1000_instance_init() 
twice)
12/21 Checking commit 62ec2adde01a (hw/arm/bcm2835: Drop futile attempts at 
QOM-adopting memory)
13/21 Checking commit 8f15bf98b7b4 (qdev: Clean up 
qdev_connect_gpio_out_named())
14/21 Checking commit 5d57342e1652 (qom: Drop parameter @errp of 
object_property_add() & friends)
WARNING: line over 80 characters
#211: FILE: backends/hostmem-file.c:187:
+        file_memory_backend_get_discard_data, 
file_memory_backend_set_discard_data);

WARNING: line over 80 characters
#1082: FILE: hw/arm/raspi.c:287:
+    object_property_add_const_link(OBJECT(&s->soc), "ram", 
OBJECT(machine->ram));

WARNING: line over 80 characters
#3116: FILE: hw/ppc/spapr.c:3336:
+                                   &spapr->kernel_addr, 
OBJ_PROP_FLAG_READWRITE);

total: 0 errors, 3 warnings, 4488 lines checked

Patch 14/21 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
15/21 Checking commit 4ff5d800fc65 (Drop more @errp parameters after previous 
commit)
16/21 Checking commit 4534b8148c84 (qdev: Unrealize must not fail)
17/21 Checking commit 6b33a0543ca0 (spapr_pci: Drop some dead error handling)
18/21 Checking commit 4f3b6eaeb71e (qom: Drop @errp parameter of 
object_property_del())
19/21 Checking commit 285893c4b20d (target: Remove unnecessary CPU() cast)
20/21 Checking commit 9f0727a49b59 (various: Remove unnecessary OBJECT() cast)
21/21 Checking commit 157b9a0efdcf (hw: Remove unnecessary DEVICE() cast)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden