Re: [PATCH 00/10] softfloat: misc cleanups

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Subject: [PATCH 00/10] softfloat: misc cleanups
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
d6c1572 softfloat: Return bool from all classification predicates
d5219e0 softfloat: Inline floatx80 compare specializations
174c114 softfloat: Inline float128 compare specializations
5359fcf softfloat: Inline float64 compare specializations
dfbd82c softfloat: Inline float32 compare specializations
4800e27 softfloat: Name compare relation enum
7fa3297 softfloat: Name rounding mode enum
7cd2649 softfloat: Change tininess_before_rounding to bool
e7c55dd softfloat: Replace flag with bool
a611c6d softfloat: Use post test for floatN_mul

=== OUTPUT BEGIN ===
1/10 Checking commit a611c6d2a057 (softfloat: Use post test for floatN_mul)
2/10 Checking commit e7c55dd7e0d5 (softfloat: Replace flag with bool)
3/10 Checking commit 7cd2649f0ce0 (softfloat: Change tininess_before_rounding 
to bool)
ERROR: space prohibited before that close parenthesis ')'
#67: FILE: fpu/softfloat.c:3877:
+                  || (zExp < 0 )

total: 1 errors, 0 warnings, 143 lines checked

Patch 3/10 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

4/10 Checking commit 7fa3297e0cfe (softfloat: Name rounding mode enum)
5/10 Checking commit 4800e2753ad9 (softfloat: Name compare relation enum)
6/10 Checking commit dfbd82cf4b75 (softfloat: Inline float32 compare 
specializations)
7/10 Checking commit 5359fcfe6a48 (softfloat: Inline float64 compare 
specializations)
8/10 Checking commit 174c1143cfd1 (softfloat: Inline float128 compare 
specializations)
9/10 Checking commit d5219e08fe69 (softfloat: Inline floatx80 compare 
specializations)
10/10 Checking commit d6c1572c791c (softfloat: Return bool from all 
classification predicates)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden