qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 13/24] ppc4xx: Drop redundant device realization


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH 13/24] ppc4xx: Drop redundant device realization
Date: Mon, 18 May 2020 10:54:10 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0

On 5/18/20 7:03 AM, Markus Armbruster wrote:
object_property_set_bool(OBJECT(dev), true, "realized", ...) right
after qdev_init_nofail(dev) does nothing, because qdev_init_nofail()
already realizes.  Drop.

Cc: BALATON Zoltan <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>
---
  hw/ppc/ppc440_uc.c | 2 --
  1 file changed, 2 deletions(-)

diff --git a/hw/ppc/ppc440_uc.c b/hw/ppc/ppc440_uc.c
index b30e093cbb..dc318c7aa7 100644
--- a/hw/ppc/ppc440_uc.c
+++ b/hw/ppc/ppc440_uc.c
@@ -1370,12 +1370,10 @@ void ppc460ex_pcie_init(CPUPPCState *env)
      dev = qdev_create(NULL, TYPE_PPC460EX_PCIE_HOST);
      qdev_prop_set_int32(dev, "dcrn-base", DCRN_PCIE0_BASE);
      qdev_init_nofail(dev);
-    object_property_set_bool(OBJECT(dev), true, "realized", NULL);
      ppc460ex_pcie_register_dcrs(PPC460EX_PCIE_HOST(dev), env);
dev = qdev_create(NULL, TYPE_PPC460EX_PCIE_HOST);
      qdev_prop_set_int32(dev, "dcrn-base", DCRN_PCIE1_BASE);
      qdev_init_nofail(dev);
-    object_property_set_bool(OBJECT(dev), true, "realized", NULL);
      ppc460ex_pcie_register_dcrs(PPC460EX_PCIE_HOST(dev), env);
  }


Reviewed-by: Philippe Mathieu-Daudé <address@hidden>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]