qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v1 3/3] virtio-balloon: unref the iothread when unrealizing


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v1 3/3] virtio-balloon: unref the iothread when unrealizing
Date: Mon, 18 May 2020 11:19:48 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0

On 5/18/20 10:37 AM, David Hildenbrand wrote:
We took a reference when realizing, so let's drop that reference when
unrealizing.

Fixes: c13c4153f76d ("virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT")
Cc: Wei Wang <address@hidden>
Cc: Alexander Duyck <address@hidden>
Cc: Michael S. Tsirkin <address@hidden>
Cc: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: David Hildenbrand <address@hidden>
---
  hw/virtio/virtio-balloon.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c
index a4fcf2d777..3f8fc50be0 100644
--- a/hw/virtio/virtio-balloon.c
+++ b/hw/virtio/virtio-balloon.c
@@ -820,6 +820,7 @@ static void virtio_balloon_device_unrealize(DeviceState 
*dev)
if (s->free_page_bh) {
          qemu_bh_delete(s->free_page_bh);
+        object_unref(OBJECT(s->iothread));
          virtio_balloon_free_page_stop(s);
          precopy_remove_notifier(&s->free_page_report_notify);
      }


Reviewed-by: Philippe Mathieu-Daudé <address@hidden>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]