[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 11/13] audio: deprecate -soundhw pcspk
From: |
Gerd Hoffmann |
Subject: |
Re: [PATCH v2 11/13] audio: deprecate -soundhw pcspk |
Date: |
Mon, 18 May 2020 15:27:45 +0200 |
Hi,
> >> Initialization order looks tricky though. I'd have to create pcspk
> >> early, simliar to flash, in pc_machine_initfn(). Problem is I don't
> >> have a isa bus yet at that point (flash is sysbus and doesn't have this
> >> problem). I'm open to suggestions hiow do deal with that best.
> >
> > Seems I've found a way to deal with that: "ISADevice *pcspk =
> > object_new(TYPE_PC_SPEAKER);" can be done before the isa bus exists
> > & we can fixup things later using qdev_set_parent_bus().
>
> You'll want to watch out for the series I hope to post shortly: it'll be
> dev = qdev_new(TYPE_PC_SPEAKER); qdev_realize(dev, bus, errp) then. No
> need for qdev_set_parent_bus().
Ah, cool, that shows that I'm on the right path with my idea ;)
Sneak preview:
https://git.kraxel.org/cgit/qemu/log/?h=sirius/soundhw
Suggestions for a good name? I've used "pc.pcspk" for now,
but maybe "pc.audiodev0" or "pc.sound0" is better?
take care,
Gerd
- [PATCH v2 04/13] audio: deprecate -soundhw ac97, (continued)
- [PATCH v2 04/13] audio: deprecate -soundhw ac97, Gerd Hoffmann, 2020/05/15
- [PATCH v2 02/13] stubs: add pci_create_simple, Gerd Hoffmann, 2020/05/15
- [PATCH v2 11/13] audio: deprecate -soundhw pcspk, Gerd Hoffmann, 2020/05/15
- Re: [PATCH v2 11/13] audio: deprecate -soundhw pcspk, Ján Tomko, 2020/05/15
- Re: [PATCH v2 11/13] audio: deprecate -soundhw pcspk, Gerd Hoffmann, 2020/05/18
- Re: [PATCH v2 11/13] audio: deprecate -soundhw pcspk, Daniel P . Berrangé, 2020/05/18
- Re: [PATCH v2 11/13] audio: deprecate -soundhw pcspk, Ján Tomko, 2020/05/18
- Re: [PATCH v2 11/13] audio: deprecate -soundhw pcspk, Gerd Hoffmann, 2020/05/18
- Re: [PATCH v2 11/13] audio: deprecate -soundhw pcspk, Gerd Hoffmann, 2020/05/18
- Re: [PATCH v2 11/13] audio: deprecate -soundhw pcspk, Markus Armbruster, 2020/05/18
- Re: [PATCH v2 11/13] audio: deprecate -soundhw pcspk,
Gerd Hoffmann <=
- Re: [PATCH v2 11/13] audio: deprecate -soundhw pcspk, Paolo Bonzini, 2020/05/21
Re: [PATCH v2 00/13] audio: deprecate -soundhw, Paolo Bonzini, 2020/05/18