Re: [RISU 4/9] Adjust tracefile open for write

[Peter Maydell]

On Wed, 13 May 2020 at 19:10, Richard Henderson
<address@hidden> wrote:
>
> Truncate the new output file.  Rely on umask to remove
> group+other file permissions, if desired.
>
> Signed-off-by: Richard Henderson <address@hidden>
> ---
>  risu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/risu.c b/risu.c
> index 1c66885..f404d8f 100644
> --- a/risu.c
> +++ b/risu.c
> @@ -368,7 +368,7 @@ int main(int argc, char **argv)
>              comm_fd = ismaster ? STDOUT_FILENO : STDIN_FILENO;
>          } else {
>              if (ismaster) {
> -                comm_fd = open(trace_fn, O_WRONLY | O_CREAT, S_IRWXU);
> +                comm_fd = open(trace_fn, O_WRONLY | O_CREAT | O_TRUNC, 0666);
>              } else {
>                  comm_fd = open(trace_fn, O_RDONLY);
>              }

I dunno why we were giving it execute permissions...

Reviewed-by: Peter Maydell <address@hidden>

thanks
-- PMM