Re: [PATCH RFC v2 2/5] blockdev: combine DriveBackupState and BlockdevBackupState

[Eric Blake]

On 5/13/20 10:49 PM, John Snow wrote:
> They have the same fields -- rename it BlockJobState.

This says BlockJobState...

> Signed-off-by: John Snow <address@hidden>
> ---
>   blockdev.c | 30 ++++++++++++------------------
>   1 file changed, 12 insertions(+), 18 deletions(-)
>
> diff --git a/blockdev.c b/blockdev.c
> index b3c840ec03..d3e8a6ca22 100644
> --- a/blockdev.c
> +++ b/blockdev.c
> @@ -1702,11 +1702,11 @@ static void external_snapshot_clean(BlkActionState 
> *common)
>       aio_context_release(aio_context);
>   }
>   
> -typedef struct DriveBackupState {
> +typedef struct BlockJobActionState {

...but this does not.  I'm assuming it is just a typo in the commit message?

Otherwise,
Reviewed-by: Eric Blake <address@hidden>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org