Re: [PATCH 1/4] target/i386: fix floating-point load-constant rounding

[Richard Henderson]

On 5/13/20 4:49 PM, Joseph Myers wrote:
> The implementations of the fldl2t, fldl2e, fldpi, fldlg2 and fldln2
> instructions load fixed constants independent of the rounding mode.
> Fix them to load a value correctly rounded for the current rounding
> mode (but always rounded to 64-bit precision independent of the
> precision control, and without setting "inexact") as specified.
> 
> Signed-off-by: Joseph Myers <address@hidden>
> ---
>  target/i386/fpu_helper.c          |  54 +++++++-
>  tests/tcg/i386/test-i386-fldcst.c | 199 ++++++++++++++++++++++++++++++
>  2 files changed, 248 insertions(+), 5 deletions(-)
>  create mode 100644 tests/tcg/i386/test-i386-fldcst.c

Reviewed-by: Richard Henderson <address@hidden>

r~