[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 53/55] qdev: Convert bus-less devices to qdev_realize() with
|
From: |
Alistair Francis |
|
Subject: |
Re: [PATCH 53/55] qdev: Convert bus-less devices to qdev_realize() with Coccinelle |
|
Date: |
Tue, 19 May 2020 14:28:32 -0700 |
On Tue, May 19, 2020 at 8:29 AM Markus Armbruster <address@hidden> wrote:
>
> All remaining conversions to qdev_realize() are for bus-less devices.
> Coccinelle script:
>
> // only correct for bus-less @dev!
>
> @@
> expression errp;
> expression dev;
> @@
> - qdev_init_nofail(dev);
> + qdev_realize(dev, NULL, &error_fatal);
>
> @ depends on !(file in "hw/core/qdev.c") && !(file in "hw/core/bus.c")@
> expression errp;
> expression dev;
> symbol true;
> @@
> - object_property_set_bool(OBJECT(dev), true, "realized", errp);
> + qdev_realize(DEVICE(dev), NULL, errp);
>
> @ depends on !(file in "hw/core/qdev.c") && !(file in "hw/core/bus.c")@
> expression errp;
> expression dev;
> symbol true;
> @@
> - object_property_set_bool(dev, true, "realized", errp);
> + qdev_realize(DEVICE(dev), NULL, errp);
>
> Note that Coccinelle chokes on ARMSSE typedef vs. macro in
> hw/arm/armsse.c. Worked around by temporarily renaming the macro for
> the spatch run.
>
> Signed-off-by: Markus Armbruster <address@hidden>
Acked-by: Alistair Francis <address@hidden>
Alistair
> --
> 2.21.1
>
>
- [PATCH 35/55] macio: Convert use of qdev_set_parent_bus(), (continued)
- [PATCH 35/55] macio: Convert use of qdev_set_parent_bus(), Markus Armbruster, 2020/05/19
- [PATCH 36/55] macio: Eliminate macio_init_child_obj(), Markus Armbruster, 2020/05/19
- [PATCH 42/55] sysbus: New sysbus_realize(), sysbus_realize_and_unref(), Markus Armbruster, 2020/05/19
- [PATCH 22/55] ssi: Convert uses of ssi_create_slave_no_init() with Coccinelle, Markus Armbruster, 2020/05/19
- [PATCH 27/55] usb: usb_create() is now unused, drop, Markus Armbruster, 2020/05/19
- [PATCH 45/55] sysbus: Convert qdev_set_parent_bus() use with Coccinelle, part 1, Markus Armbruster, 2020/05/19
- [PATCH 53/55] qdev: Convert bus-less devices to qdev_realize() with Coccinelle, Markus Armbruster, 2020/05/19
- Re: [PATCH 53/55] qdev: Convert bus-less devices to qdev_realize() with Coccinelle,
Alistair Francis <=
- [PATCH 08/55] qdev: Convert uses of qdev_create() with Coccinelle, Markus Armbruster, 2020/05/19
- [PATCH 28/55] usb: Eliminate usb_try_create_simple(), Markus Armbruster, 2020/05/19
- [PATCH 43/55] sysbus: Convert to sysbus_realize() etc. with Coccinelle, Markus Armbruster, 2020/05/19
- [PATCH 55/55] MAINTAINERS: Make section QOM cover hw/core/*bus.c as well, Markus Armbruster, 2020/05/19
- [PATCH 21/55] ssi: ssi_auto_connect_slaves() never does anything, drop, Markus Armbruster, 2020/05/19