Re: [PATCH 3/7] chardev/char.c: Use qemu_co_sleep_ns if in coroutine

[Philippe Mathieu-Daudé]

On 5/19/20 10:02 PM, Zhang Chen wrote:
> From: Lukas Straub <address@hidden>
>
> This will be needed in the next patch.

Can you reword to something clearer, maybe:

"To be able to convert compare_chr_send to a coroutine in the
next commit, use qemu_co_sleep_ns if in coroutine."

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>

> Signed-off-by: Lukas Straub <address@hidden>
> Reviewed-by: Marc-André Lureau <address@hidden>
> Reviewed-by: Zhang Chen <address@hidden>
> Signed-off-by: Zhang Chen <address@hidden>
> ---
>   chardev/char.c | 7 ++++++-
>   1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/chardev/char.c b/chardev/char.c
> index 0196e2887b..4c58ea1836 100644
> --- a/chardev/char.c
> +++ b/chardev/char.c
> @@ -38,6 +38,7 @@
>   #include "qemu/module.h"
>   #include "qemu/option.h"
>   #include "qemu/id.h"
> +#include "qemu/coroutine.h"
>   
>   #include "chardev/char-mux.h"
>   
> @@ -119,7 +120,11 @@ static int qemu_chr_write_buffer(Chardev *s,
>       retry:
>           res = cc->chr_write(s, buf + *offset, len - *offset);
>           if (res < 0 && errno == EAGAIN && write_all) {
> -            g_usleep(100);
> +            if (qemu_in_coroutine()) {
> +                qemu_co_sleep_ns(QEMU_CLOCK_REALTIME, 100000);
> +            } else {
> +                g_usleep(100);
> +            }
>               goto retry;
>           }
>