[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 6/6] migration/block-dirty-bitmap: forbid migration by generat
From: |
Vladimir Sementsov-Ogievskiy |
Subject: |
[PATCH v4 6/6] migration/block-dirty-bitmap: forbid migration by generated node-name |
Date: |
Fri, 22 May 2020 01:06:48 +0300 |
It actually never worked with libvirt, as auto-generated names are
different on source and destination.
It's unsafe and useless to migrate by auto-generated node-names, so
let's forbid it.
Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Reviewed-by: Andrey Shinkevich <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
---
migration/block-dirty-bitmap.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/migration/block-dirty-bitmap.c b/migration/block-dirty-bitmap.c
index 65f2948f07..71528581e4 100644
--- a/migration/block-dirty-bitmap.c
+++ b/migration/block-dirty-bitmap.c
@@ -285,6 +285,13 @@ static int add_bitmaps_to_list(BlockDriverState *bs, const
char *bs_name)
return -1;
}
+ if (bs_name[0] == '#') {
+ error_report("Bitmap '%s' in a node with auto-generated "
+ "name '%s' can't be migrated",
+ bdrv_dirty_bitmap_name(bitmap), bs_name);
+ return -1;
+ }
+
FOR_EACH_DIRTY_BITMAP(bs, bitmap) {
if (!bdrv_dirty_bitmap_name(bitmap)) {
continue;
--
2.21.0
- [PATCH v4 0/6] fix migration with bitmaps and mirror, Vladimir Sementsov-Ogievskiy, 2020/05/21
- [PATCH v4 1/6] migration/block-dirty-bitmap: refactor init_dirty_bitmap_migration, Vladimir Sementsov-Ogievskiy, 2020/05/21
- [PATCH v4 2/6] block/dirty-bitmap: add bdrv_has_named_bitmaps helper, Vladimir Sementsov-Ogievskiy, 2020/05/21
- [PATCH v4 3/6] migration/block-dirty-bitmap: fix bitmaps pre-blockdev migration during mirror job, Vladimir Sementsov-Ogievskiy, 2020/05/21
- [PATCH v4 4/6] iotests: 194: test also migration of dirty bitmap, Vladimir Sementsov-Ogievskiy, 2020/05/21
- [PATCH v4 5/6] migration/block-dirty-bitmap: add_bitmaps_to_list: check disk name once, Vladimir Sementsov-Ogievskiy, 2020/05/21
- [PATCH v4 6/6] migration/block-dirty-bitmap: forbid migration by generated node-name,
Vladimir Sementsov-Ogievskiy <=
- Re: [PATCH v4 0/6] fix migration with bitmaps and mirror, Eric Blake, 2020/05/22