[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 04/10] linux-user: completely re-write init_guest_space
From: |
Peter Maydell |
Subject: |
Re: [PATCH v1 04/10] linux-user: completely re-write init_guest_space |
Date: |
Fri, 22 May 2020 11:36:57 +0100 |
On Fri, 22 May 2020 at 11:24, Alex Bennée <address@hidden> wrote:
> Examples:
>
> /tmp/qemu-test/src/fpu/softfloat.c:3365:13: error: bitwise negation of a
> boolean expression; did you mean logical negation? [-Werror,-Wbool-operation]
> absZ &= ~ ( ( ( roundBits ^ 0x40 ) == 0 ) & roundNearestEven );
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> !
> /tmp/qemu-test/src/fpu/softfloat.c:3423:18: error: bitwise negation of a
> boolean expression; did you mean logical negation? [-Werror,-Wbool-operation]
> absZ0 &= ~ ( ( (uint64_t) ( absZ1<<1 ) == 0 ) & roundNearestEven );
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> !
These warnings as printed seem like compiler bugs -- '&' is a bitwise
operator, not a boolean one. (Probably the compiler intends to warn
about use of the bitwise & on the boolean == result, though.)
thanks
-- PMM
- Re: [PATCH v1 01/10] tests/guest-debug: catch hanging guests, (continued)
[PATCH v1 06/10] accel/tcg: Relax va restrictions on 64-bit guests, Alex Bennée, 2020/05/13
[PATCH v1 09/10] disas: add optional note support to cap_disas, Alex Bennée, 2020/05/13
[PATCH v1 10/10] translate-all: include guest address in out_asm output, Alex Bennée, 2020/05/13
[PATCH v1 08/10] disas: include an optional note for the start of disassembly, Alex Bennée, 2020/05/13