[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 11/19] accel/tcg: Fixed tsan warnings related to parallel_cpu
From: |
Emilio G. Cota |
Subject: |
Re: [PATCH 11/19] accel/tcg: Fixed tsan warnings related to parallel_cpus |
Date: |
Sat, 23 May 2020 13:21:10 -0400 |
On Fri, May 22, 2020 at 12:07:47 -0400, Robert Foley wrote:
> Fixed several tsan warnings. e.g.
>
> WARNING: ThreadSanitizer: data race (pid=35425)
> Read of size 1 at 0x557cd83aee28 by thread T7:
> #0 curr_cflags include/exec/exec-all.h:460:13
> (qemu-system-aarch64+0x4b7f27)
> #1 cpu_exec accel/tcg/cpu-exec.c:730:26 (qemu-system-aarch64+0x4b7f27)
> #2 tcg_cpu_exec cpus.c:1415:11 (qemu-system-aarch64+0x45b9b6)
> #3 qemu_tcg_cpu_thread_fn cpus.c:1723:17 (qemu-system-aarch64+0x45b9b6)
> #4 qemu_thread_start util/qemu-thread-posix.c:519:9
> (qemu-system-aarch64+0xd431e0)
>
> Previous write of size 1 at 0x557cd83aee28 by thread T6:
> #0 cpu_exec_step_atomic accel/tcg/cpu-exec.c:254:23
> (qemu-system-aarch64+0x4b6caa)
> #1 qemu_tcg_cpu_thread_fn cpus.c:1741:17 (qemu-system-aarch64+0x45baca)
> #2 qemu_thread_start util/qemu-thread-posix.c:519:9
> (qemu-system-aarch64+0xd431e0)
>
> Location is global 'parallel_cpus' of size 1 at 0x557cd83aee28
> (qemu-system-aarch64+0x000001fb3e28)
>
> Cc: Richard Henderson <address@hidden>
> Cc: Paolo Bonzini <address@hidden>
> Signed-off-by: Robert Foley <address@hidden>
Reviewed-by: Emilio G. Cota <address@hidden>
E.
- [PATCH 02/19] cpu: convert queued work to a QSIMPLEQ, (continued)
- [PATCH 02/19] cpu: convert queued work to a QSIMPLEQ, Robert Foley, 2020/05/22
- [PATCH 03/19] thread: add qemu_spin_destroy, Robert Foley, 2020/05/22
- [PATCH 04/19] cputlb: destroy CPUTLB with tlb_destroy, Robert Foley, 2020/05/22
- [PATCH 06/19] tcg: call qemu_spin_destroy for tb->jmp_lock, Robert Foley, 2020/05/22
- [PATCH 07/19] translate-all: call qemu_spin_destroy for PageDesc, Robert Foley, 2020/05/22
- [PATCH 08/19] thread: add tsan annotations to QemuSpin, Robert Foley, 2020/05/22
- [PATCH 09/19] tests/docker: Added docker build support for TSan., Robert Foley, 2020/05/22
- [PATCH 11/19] accel/tcg: Fixed tsan warnings related to parallel_cpus, Robert Foley, 2020/05/22
- Re: [PATCH 11/19] accel/tcg: Fixed tsan warnings related to parallel_cpus,
Emilio G. Cota <=
- [PATCH 10/19] include/qemu: Added tsan.h for annotations., Robert Foley, 2020/05/22
- [PATCH 12/19] configure: added tsan support for blacklist., Robert Foley, 2020/05/22
- [PATCH 13/19] accel/tcg: Fixed tsan warnings., Robert Foley, 2020/05/22