[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] block/block-copy: block_copy_dirty_clusters: fix failure check
From: |
Vladimir Sementsov-Ogievskiy |
Subject: |
[PATCH] block/block-copy: block_copy_dirty_clusters: fix failure check |
Date: |
Tue, 26 May 2020 21:13:47 +0300 |
ret may be > 0 on success path at this point. Fix assertion, which may
crash currently.
Fixes: 4ce5dd3e9b5ee0fac18625860eb3727399ee965e
Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
---
block/block-copy.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/block/block-copy.c b/block/block-copy.c
index bb8d0569f2..f7428a7c08 100644
--- a/block/block-copy.c
+++ b/block/block-copy.c
@@ -622,8 +622,10 @@ out:
* block_copy_task_run. If it fails, it means some task already failed
* for real reason, let's return first failure.
* Still, assert that we don't rewrite failure by success.
+ *
+ * Note: ret may be positive here because of block-status result.
*/
- assert(ret == 0 || aio_task_pool_status(aio) < 0);
+ assert(ret >= 0 || aio_task_pool_status(aio) < 0);
ret = aio_task_pool_status(aio);
aio_task_pool_free(aio);
--
2.18.0
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [PATCH] block/block-copy: block_copy_dirty_clusters: fix failure check,
Vladimir Sementsov-Ogievskiy <=