[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 01/10] nvdimm: Plug memory leak in uuid property setter
From: |
Markus Armbruster |
Subject: |
[PULL 01/10] nvdimm: Plug memory leak in uuid property setter |
Date: |
Wed, 27 May 2020 07:59:36 +0200 |
nvdimm_set_uuid() leaks memory on qemu_uuid_parse() failure. Fix
that.
Fixes: 6c5627bb24dcd68c997857a8b671617333b1289f
Cc: Xiao Guangrong <address@hidden>
Cc: Shivaprasad G Bhat <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>
Message-Id: <address@hidden>
Tested-by: Shivaprasad G Bhat <address@hidden>
Reviewed-by: Shivaprasad G Bhat <address@hidden>
---
hw/mem/nvdimm.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/mem/nvdimm.c b/hw/mem/nvdimm.c
index c5adedcc69..76f66e0b19 100644
--- a/hw/mem/nvdimm.c
+++ b/hw/mem/nvdimm.c
@@ -97,7 +97,6 @@ static void nvdimm_set_uuid(Object *obj, Visitor *v, const
char *name,
if (qemu_uuid_parse(value, &nvdimm->uuid) != 0) {
error_setg(errp, "Property '%s.%s' has invalid value",
object_get_typename(obj), name);
- goto out;
}
g_free(value);
--
2.21.3
- [PULL 00/10] Error reporting patches for 2020-05-27, Markus Armbruster, 2020/05/27
- [PULL 01/10] nvdimm: Plug memory leak in uuid property setter,
Markus Armbruster <=
- [PULL 10/10] i386: Fix x86_cpu_load_model() error API violation, Markus Armbruster, 2020/05/27
- [PULL 03/10] s390x/cpumodel: Fix harmless misuse of visit_check_struct(), Markus Armbruster, 2020/05/27
- [PULL 05/10] error: Use error_reportf_err() where appropriate, Markus Armbruster, 2020/05/27
- [PULL 04/10] tests/migration: Tighten error checking, Markus Armbruster, 2020/05/27
- [PULL 06/10] mips/malta: Fix create_cps() error handling, Markus Armbruster, 2020/05/27
- [PULL 02/10] xen: Fix and improve handling of device_add usb-host errors, Markus Armbruster, 2020/05/27
- [PULL 08/10] mips/boston: Plug memory leak in boston_mach_init(), Markus Armbruster, 2020/05/27
- [PULL 09/10] arm/sabrelite: Consistently use &error_fatal in sabrelite_init(), Markus Armbruster, 2020/05/27
- [PULL 07/10] mips/boston: Fix boston_mach_init() error handling, Markus Armbruster, 2020/05/27
- Re: [PULL 00/10] Error reporting patches for 2020-05-27, Peter Maydell, 2020/05/28