[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 09/24] macio: Fix to realize "mos6522-cuda" and "mos6522-pmu"
|
From: |
Peter Maydell |
|
Subject: |
Re: [PATCH 09/24] macio: Fix to realize "mos6522-cuda" and "mos6522-pmu" devices |
|
Date: |
Wed, 27 May 2020 16:05:15 +0100 |
On Wed, 27 May 2020 at 15:12, Markus Armbruster <address@hidden> wrote:
> * PATCH 08: in a realize method. Can't actually fail, so let's use
> &error_abort.
>
> * PATCH 09 (this one): likewise.
I disagree with these. We're in a realize function, the API
says "on errors, report them via the Error* you got passed",
so we should do that, not blow up. &error_abort only makes
sense if (a) we have no better way to report errors than
to abort (which isn't the case here) or (b) if we can guarantee
that in fact the thing we're doing won't ever fail
(which we can't here without knowing more about the internal
implementation details of the MOS6522 device than we
really ought to).
thanks
-- PMM
- Re: [PATCH 04/24] aspeed: Don't create unwanted "ftgmac100", "aspeed-mmi" devices, (continued)
[PATCH 08/24] mac_via: Fix to realize "mos6522-q800-via*" devices, Markus Armbruster, 2020/05/18
[PATCH 12/24] MAINTAINERS: Make section PowerNV cover pci-host/pnv* as well, Markus Armbruster, 2020/05/18
[PATCH 09/24] macio: Fix to realize "mos6522-cuda" and "mos6522-pmu" devices, Markus Armbruster, 2020/05/18
[PATCH 07/24] auxbus: Fix aux-to-i2c-bridge to be a subtype of aux-slave, Markus Armbruster, 2020/05/18
[PATCH 02/24] display/xlnx_dp: Fix to realize "i2c-ddc" and "aux-to-i2c-bridge", Markus Armbruster, 2020/05/18