RE: [PATCH v6 2/5] block: consolidate blocksize properties consistency checks

[Paul Durrant]

> -----Original Message-----
> From: Roman Kagan <rvkagan@yandex-team.ru>
> Sent: 27 May 2020 13:45
> To: qemu-devel@nongnu.org
> Cc: Kevin Wolf <kwolf@redhat.com>; xen-devel@lists.xenproject.org; Gerd 
> Hoffmann <kraxel@redhat.com>;
> Daniel P. Berrangé <berrange@redhat.com>; Paolo Bonzini 
> <pbonzini@redhat.com>; Anthony Perard
> <anthony.perard@citrix.com>; Laurent Vivier <laurent@vivier.eu>; Max Reitz 
> <mreitz@redhat.com>; qemu-
> block@nongnu.org; Philippe Mathieu-Daudé <philmd@redhat.com>; Eric Blake 
> <eblake@redhat.com>; Paul
> Durrant <paul@xen.org>; Fam Zheng <fam@euphon.net>; John Snow 
> <jsnow@redhat.com>; Michael S. Tsirkin
> <mst@redhat.com>; Eduardo Habkost <ehabkost@redhat.com>; Keith Busch 
> <kbusch@kernel.org>; Stefano
> Stabellini <sstabellini@kernel.org>; Stefan Hajnoczi <stefanha@redhat.com>
> Subject: [PATCH v6 2/5] block: consolidate blocksize properties consistency 
> checks
> 
> Several block device properties related to blocksize configuration must
> be in certain relationship WRT each other: physical block must be no
> smaller than logical block; min_io_size, opt_io_size, and
> discard_granularity must be a multiple of a logical block.
> 
> To ensure these requirements are met, add corresponding consistency
> checks to blkconf_blocksizes, adjusting its signature to communicate
> possible error to the caller.  Also remove the now redundant consistency
> checks from the specific devices.
> 
> Signed-off-by: Roman Kagan <rvkagan@yandex-team.ru>

Reviewed-by: Paul Durrant <paul@xen.org>