[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/5] Add strace support for printing arguments of selected sy
From: |
no-reply |
Subject: |
Re: [PATCH 0/5] Add strace support for printing arguments of selected syscalls |
Date: |
Tue, 2 Jun 2020 06:42:40 -0700 (PDT) |
Patchew URL:
20200602115331.1659-1-filip.bozuta@syrmia.com/">https://patchew.org/QEMU/20200602115331.1659-1-filip.bozuta@syrmia.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20200602115331.1659-1-filip.bozuta@syrmia.com
Subject: [PATCH 0/5] Add strace support for printing arguments of selected
syscalls
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
- [tag update] patchew/20200529221450.26673-1-alxndr@bu.edu ->
patchew/20200529221450.26673-1-alxndr@bu.edu
Switched to a new branch 'test'
b550765 linux-user: Add strace support for printing arguments of fallocate()
5330146 linux-user: Add strace support for printing arguments of
chown()/lchown()
989e4e7 linux-user: Add strace support for printing arguments of lseek()
b783ad4 linux-user: Add strace support for printing argument of syscalls used
for extend attributes
3e8a5b0 linux-user: Add strace support for a group of syscalls
=== OUTPUT BEGIN ===
1/5 Checking commit 3e8a5b0eb48a (linux-user: Add strace support for a group of
syscalls)
2/5 Checking commit b783ad4bf62e (linux-user: Add strace support for printing
argument of syscalls used for extend attributes)
3/5 Checking commit 989e4e773fae (linux-user: Add strace support for printing
arguments of lseek())
WARNING: Block comments use a leading /* on a separate line
#64: FILE: linux-user/strace.c:1797:
+ qemu_log(" /* SEEK_??? */");
total: 0 errors, 1 warnings, 46 lines checked
Patch 3/5 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/5 Checking commit 53301467fe82 (linux-user: Add strace support for printing
arguments of chown()/lchown())
5/5 Checking commit b55076575a2a (linux-user: Add strace support for printing
arguments of fallocate())
ERROR: storage class should be at the beginning of the declaration
#65: FILE: linux-user/strace.c:1116:
+UNUSED static struct flags falloc_flags[] = {
total: 1 errors, 0 warnings, 82 lines checked
Patch 5/5 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
20200602115331.1659-1-filip.bozuta@syrmia.com/testing.checkpatch/?type=message">http://patchew.org/logs/20200602115331.1659-1-filip.bozuta@syrmia.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
- [PATCH 2/5] linux-user: Add strace support for printing argument of syscalls used for extend attributes, (continued)
- [PATCH 2/5] linux-user: Add strace support for printing argument of syscalls used for extend attributes, Filip Bozuta, 2020/06/02
- [PATCH 1/5] linux-user: Add strace support for a group of syscalls, Filip Bozuta, 2020/06/02
- [PATCH 4/5] linux-user: Add strace support for printing arguments of chown()/lchown(), Filip Bozuta, 2020/06/02
- [PATCH 5/5] linux-user: Add strace support for printing arguments of fallocate(), Filip Bozuta, 2020/06/02
- [PATCH 3/5] linux-user: Add strace support for printing arguments of lseek(), Filip Bozuta, 2020/06/02
- Re: [PATCH 0/5] Add strace support for printing arguments of selected syscalls,
no-reply <=
- Re: [PATCH 0/5] Add strace support for printing arguments of selected syscalls, Alex Bennée, 2020/06/03