Re: [RFC v3 8/8] vhost-vdpa: introduce vhost-vdpa net client

[Cindy Lu]

Hi Jason,


On Wed, Jun 3, 2020 at 4:43 PM Jason Wang <jasowang@redhat.com> wrote:
>
>
> On 2020/6/3 下午4:19, Cindy Lu wrote:
> >>> +static void vhost_vdpa_cleanup(NetClientState *nc)
> >>> +{
> >>> +    VhostVDPAState *s = DO_UPCAST(VhostVDPAState, nc, nc);
> >>> +
> >>> +    if (s->vhost_net) {
> >>> +        vhost_net_cleanup(s->vhost_net);
> >>> +        g_free(s->vhost_net);
> >>> +        s->vhost_net = NULL;
> >>> +    }
> >>> +
> >>> +    qemu_purge_queued_packets(nc);
> >> Why this is needed?
> >>
> >> Thanks
> >>
> > This is to clean the packet in the queue while the vdpa remove,  I
> > will double check this part
>
>
> Note we don't have a software backup driver for qemu currently (we
> probably need one in the future).
>
> So we can't fallback into userspace which means the packet can not be
> queued by qemu.
>
Got it, Thanks Jason, I will remove this part

> Thanks
>