[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] ati-vga: increment mm_index in ati_mm_read/write
From: |
P J P |
Subject: |
Re: [PATCH] ati-vga: increment mm_index in ati_mm_read/write |
Date: |
Wed, 3 Jun 2020 20:05:50 +0530 (IST) |
+-- On Wed, 3 Jun 2020, Gerd Hoffmann wrote --+
| Hmm, why modify mm_index? Shouldn't we just check it is non-zero
| before calling ati_mm_read/ati_mm_write?
if (s->regs.mm_index & BIT(31)) {
...
} else {
ati_mm_write(s, s->regs.mm_index + addr - MM_DATA, data, size);
}
Exit condition for recursion is to set (mm_index & BIT(31)), so recursion
would continue even with non-zero values I think.
Thank you.
--
Prasad J Pandit / Red Hat Product Security Team
8685 545E B54C 486B C6EB 271E E285 8B5A F050 DE8D