Re: [PATCH 1/2] Introduce (x86) CPU model deprecation API

[Eric Blake]

On 6/4/20 9:47 PM, Robert Hoo wrote:
> On Thu, 2020-06-04 at 06:59 -0500, Eric Blake wrote:
> > On 6/4/20 3:07 AM, Robert Hoo wrote:
> >
> > > > > +++ b/qapi/machine-target.json
> > > > > @@ -309,7 +309,8 @@
> > > > >                 'static': 'bool',
> > > > >                 '*unavailable-features': [ 'str' ],
> > > > >                 'typename': 'str',
> > > > > -            '*alias-of' : 'str' },
> > > > > +            '*alias-of' : 'str',
> > > > > +            'deprecated' : 'bool' },
> > > >
> > > > Missing documentation of the new member.  Should it be optional
> > > > (present
> > > > only when true)?
> > >
> > > Which document do you mean?
>
> Thanks Eric:)
>
> > A few lines earlier is '@alias-of: ...'; you'll need to add a
> > similar
> > line for '@deprecated', mentioning it is '(since 5.1)'.
> >
> > > How to make it optional?
>
> How about not making it optional? refer to Machineinfo::deprecated.

Always providing it doesn't hurt.  If there is precedence for not making 
it optional, mentioning that precedence in the commit message can't hurt.

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org