[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 11/11] accel/tcg: Add stub for probe_access()
From: |
Alex Bennée |
Subject: |
Re: [PATCH v6 11/11] accel/tcg: Add stub for probe_access() |
Date: |
Mon, 08 Jun 2020 12:08:40 +0100 |
User-agent: |
mu4e 1.5.2; emacs 28.0.50 |
Philippe Mathieu-Daudé <philmd@redhat.com> writes:
> From: Philippe Mathieu-Daudé <f4bug@amsat.org>
>
> The TCG helpers where added in b92e5a22ec3 in softmmu_template.h.
> probe_write() was added in there in 3b4afc9e75a to be moved out
> to accel/tcg/cputlb.c in 3b08f0a9254, and was later refactored
> as probe_access() in c25c283df0f.
> Since it is a TCG specific helper, add a stub to avoid failures
> when building without TCG, such:
>
> target/arm/helper.o: In function `probe_read':
> include/exec/exec-all.h:362: undefined reference to `probe_access'
>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> Reviewed-by: David Hildenbrand <david@redhat.com>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
--
Alex Bennée
- Re: [PATCH v6 06/11] Makefile: Remove dangerous EOL trailing backslash, (continued)
- [PATCH v6 07/11] Makefile: Write MINIKCONF variables as one entry per line, Philippe Mathieu-Daudé, 2020/06/05
- [PATCH v6 08/11] accel/Kconfig: Extract accel selectors into their own config, Philippe Mathieu-Daudé, 2020/06/05
- [PATCH v6 09/11] accel/Kconfig: Add the TCG selector, Philippe Mathieu-Daudé, 2020/06/05
- [PATCH v6 10/11] Makefile: Allow target-specific optional Kconfig, Philippe Mathieu-Daudé, 2020/06/05
- [PATCH v6 11/11] accel/tcg: Add stub for probe_access(), Philippe Mathieu-Daudé, 2020/06/05
- Re: [PATCH v6 11/11] accel/tcg: Add stub for probe_access(),
Alex Bennée <=