[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1] hmp: Make json format optional for qom-set
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [PATCH v1] hmp: Make json format optional for qom-set |
|
Date: |
Mon, 8 Jun 2020 16:16:04 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 |
On 08/06/20 16:06, David Hildenbrand wrote:
> {
> .name = "qom-set",
> - .args_type = "path:s,property:s,value:S",
> - .params = "path property value",
> - .help = "set QOM property",
> + .args_type = "json:-j,path:s,property:s,value:s",
I think this should remain an uppercase "S", so that it grabs the rest
of the input rather than stop at the first space.
Paolo
> + .params = "[-j] path property value",
> + .help = "set QOM property.\n\t\t\t"
> + "-j: the property is specified in json format.",
> .cmd = hmp_qom_set,
> .flags = "p",
> },
> diff --git a/qom/qom-hmp-cmds.c b/qom/qom-hmp-cmds.c