qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 02/12] qcow2.py: move qcow2 format classes to separate mod


From: Eric Blake
Subject: Re: [PATCH v4 02/12] qcow2.py: move qcow2 format classes to separate module
Date: Mon, 8 Jun 2020 10:20:53 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0

On 6/6/20 2:03 AM, Vladimir Sementsov-Ogievskiy wrote:
05.06.2020 23:14, Eric Blake wrote:
On 6/4/20 12:41 PM, Vladimir Sementsov-Ogievskiy wrote:
We are going to enhance qcow2 format parsing by adding more structure
classes. Let's split format parsing from utility code.

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
---

+++ b/tests/qemu-iotests/qcow2.py
@@ -1,163 +1,10 @@
  #!/usr/bin/env python3
-
  import sys

Pre-existing: no copyright blurb on the old file...

+++ b/tests/qemu-iotests/qcow2_format.py
@@ -0,0 +1,157 @@
+import struct
+import string
+

It would be nice to fix that, and have one on the new file as well.



Yes, I thought about this.. But what to add? Seems OK to add Virtuozzo copyright and common "This program is free software; you can redist... GPL ..." header to qcow2_format.py, as we are going to rewrite and improve it a lot. But what to add to qcow2.py, to the part which is kept mostly unchanged?

Late answer, since I see you've already posted v5, but any file without an explicit header is implicitly GPLv2+ by virtue of the top-level LICENSE file.

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org




reply via email to

[Prev in Thread] Current Thread [Next in Thread]