Re: [PATCH v5 02/13] qcow2.py: add licensing blurb

[Eric Blake]

On 6/6/20 3:17 AM, Vladimir Sementsov-Ogievskiy wrote:
> Add classic heading, which is missing here. Keep copyright place empty,
> for anyone who have added (or will add) some intellectual property
> here.

It's not so much intellectual property (since that term is at odds with 
open source), but authorship rights.

Looking at git history, the file has been touched by:

Kevin Wolf
Stefan Hajnoczi (while at IBM)
Eduardo Habkost
Max Reitz
Philippe Mathieu-Daudé
Paolo Bonzini

where Stefan was the only contributor without a redhat.com address at 
the time.  So if anything, a Red Hat copyright is most likely; but you 
are also correct that it is incorrect to add a copyright line on someone 
else's behalf without their permission.

> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
>   tests/qemu-iotests/qcow2.py | 16 ++++++++++++++++
>   1 file changed, 16 insertions(+)
>
> diff --git a/tests/qemu-iotests/qcow2.py b/tests/qemu-iotests/qcow2.py
> index d99f4ee3e8..2da434a013 100755
> --- a/tests/qemu-iotests/qcow2.py
> +++ b/tests/qemu-iotests/qcow2.py
> @@ -1,4 +1,20 @@
>   #!/usr/bin/env python3
> +#
> +# Manipulations with qcow2 image
> +#

I've cc'd all prior authors; if Kevin agrees, and unless anyone speaks 
up to the contrary, I'm willing to add:

# Copyright (C) 2012 Red Hat, Inc.

for Kevin's initial contribution, without worrying about subsequent 
contributions.

> +# This program is free software; you can redistribute it and/or modify
> +# it under the terms of the GNU General Public License as published by
> +# the Free Software Foundation; either version 2 of the License, or
> +# (at your option) any later version.
> +#
> +# This program is distributed in the hope that it will be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +# GNU General Public License for more details.
> +#
> +# You should have received a copy of the GNU General Public License
> +# along with this program.  If not, see <http://www.gnu.org/licenses/>.
> +#
>   
>   import sys
>   import struct

Adding a copyright line could be a followup patch, so in the meantime, 
making what was previously an implicit license now explicit is fine even 
if it is odd to assert GPL without also asserting Copyright.

Reviewed-by: Eric Blake <eblake@redhat.com>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org