[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 02/13] qcow2.py: add licensing blurb
From: |
Eric Blake |
Subject: |
Re: [PATCH v5 02/13] qcow2.py: add licensing blurb |
Date: |
Mon, 8 Jun 2020 16:01:27 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 |
On 6/6/20 3:17 AM, Vladimir Sementsov-Ogievskiy wrote:
Add classic heading, which is missing here. Keep copyright place empty,
for anyone who have added (or will add) some intellectual property
here.
It's not so much intellectual property (since that term is at odds with
open source), but authorship rights.
Looking at git history, the file has been touched by:
Kevin Wolf
Stefan Hajnoczi (while at IBM)
Eduardo Habkost
Max Reitz
Philippe Mathieu-Daudé
Paolo Bonzini
where Stefan was the only contributor without a redhat.com address at
the time. So if anything, a Red Hat copyright is most likely; but you
are also correct that it is incorrect to add a copyright line on someone
else's behalf without their permission.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
---
tests/qemu-iotests/qcow2.py | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/tests/qemu-iotests/qcow2.py b/tests/qemu-iotests/qcow2.py
index d99f4ee3e8..2da434a013 100755
--- a/tests/qemu-iotests/qcow2.py
+++ b/tests/qemu-iotests/qcow2.py
@@ -1,4 +1,20 @@
#!/usr/bin/env python3
+#
+# Manipulations with qcow2 image
+#
I've cc'd all prior authors; if Kevin agrees, and unless anyone speaks
up to the contrary, I'm willing to add:
# Copyright (C) 2012 Red Hat, Inc.
for Kevin's initial contribution, without worrying about subsequent
contributions.
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program. If not, see <http://www.gnu.org/licenses/>.
+#
import sys
import struct
Adding a copyright line could be a followup patch, so in the meantime,
making what was previously an implicit license now explicit is fine even
if it is odd to assert GPL without also asserting Copyright.
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
- [PATCH v5 00/13] iotests: Dump QCOW2 dirty bitmaps metadata, Vladimir Sementsov-Ogievskiy, 2020/06/06
- [PATCH v5 01/13] qcow2.py: python style fixes, Vladimir Sementsov-Ogievskiy, 2020/06/06
- [PATCH v5 02/13] qcow2.py: add licensing blurb, Vladimir Sementsov-Ogievskiy, 2020/06/06
- Re: [PATCH v5 02/13] qcow2.py: add licensing blurb,
Eric Blake <=
- [PATCH v5 06/13] qcow2_format.py: use modern string formatting, Vladimir Sementsov-Ogievskiy, 2020/06/06
- [PATCH v5 05/13] qcow2_format.py: use tuples instead of lists for fields, Vladimir Sementsov-Ogievskiy, 2020/06/06
- [PATCH v5 09/13] qcow2_format.py: add field-formatting class, Vladimir Sementsov-Ogievskiy, 2020/06/06
- [PATCH v5 03/13] qcow2.py: move qcow2 format classes to separate module, Vladimir Sementsov-Ogievskiy, 2020/06/06
- [PATCH v5 04/13] qcow2_format.py: drop new line printing at end of dump(), Vladimir Sementsov-Ogievskiy, 2020/06/06
- [PATCH v5 08/13] qcow2_format.py: separate generic functionality of structure classes, Vladimir Sementsov-Ogievskiy, 2020/06/06
- [PATCH v5 07/13] qcow2_format.py: use strings to specify c-type of struct fields, Vladimir Sementsov-Ogievskiy, 2020/06/06
- [PATCH v5 10/13] qcow2_format.py: QcowHeaderExtension: add dump method, Vladimir Sementsov-Ogievskiy, 2020/06/06