[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH 00/35] hw/qdev: Warn when using pre-qdev/QOM devices
From: |
Paolo Bonzini |
Subject: |
Re: [RFC PATCH 00/35] hw/qdev: Warn when using pre-qdev/QOM devices |
Date: |
Tue, 9 Jun 2020 13:14:43 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 |
On 08/06/20 18:17, Philippe Mathieu-Daudé wrote:
> On 6/8/20 6:14 PM, Peter Maydell wrote:
>> On Mon, 8 Jun 2020 at 17:00, Philippe Mathieu-Daudé <philmd@redhat.com>
>> wrote:
>>>
>>> Based on today's IRC chat, this is a trivial RFC series
>>> to anotate pre-qdev/QOM devices so developers using them
>>> without knowing they are not QOM'ified yet can realize
>>> it and convert them if they have time.
>>
>> What mechanism did you use for identifying non-QOM devices?
>
> I don't think this is the complete list, this is only all the one I
> could find with:
>
> $ git grep "g_new|g_malloc" hw/
>
> Then on each match I manually reviewed (so I might have incorrectly
> flagged code too).
Yes, you did, but I guess for an RFC it was a good bang for the buck. I
went through the patch and noticed both a few false positives and a
couple blatant violations in recent code.
Paolo
- Re: [RFC PATCH 30/35] hw/ppc/virtex_ml507: Emit warning when old code is used, (continued)
- [RFC PATCH 31/35] hw/sh4: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08
- [RFC PATCH 32/35] hw/riscv: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08
- [RFC PATCH 33/35] hw/timer/slavio_timer: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08
- [RFC PATCH 34/35] hw/usb/hcd-musb: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08
- [RFC PATCH 35/35] hw/xtensa/xtfpga: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08
- Re: [RFC PATCH 00/35] hw/qdev: Warn when using pre-qdev/QOM devices, Peter Maydell, 2020/06/08