[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 07/13] translate-all: call qemu_spin_destroy for PageDesc
From: |
Robert Foley |
Subject: |
[PATCH v3 07/13] translate-all: call qemu_spin_destroy for PageDesc |
Date: |
Tue, 9 Jun 2020 16:07:32 -0400 |
From: "Emilio G. Cota" <cota@braap.org>
The radix tree is append-only, but we can fail to insert
a PageDesc if the insertion races with another thread.
Signed-off-by: Emilio G. Cota <cota@braap.org>
Signed-off-by: Robert Foley <robert.foley@linaro.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
---
accel/tcg/translate-all.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/accel/tcg/translate-all.c b/accel/tcg/translate-all.c
index c937210e21..c3d37058a1 100644
--- a/accel/tcg/translate-all.c
+++ b/accel/tcg/translate-all.c
@@ -547,6 +547,15 @@ static PageDesc *page_find_alloc(tb_page_addr_t index, int
alloc)
#endif
existing = atomic_cmpxchg(lp, NULL, pd);
if (unlikely(existing)) {
+#ifndef CONFIG_USER_ONLY
+ {
+ int i;
+
+ for (i = 0; i < V_L2_SIZE; i++) {
+ qemu_spin_destroy(&pd[i].lock);
+ }
+ }
+#endif
g_free(pd);
pd = existing;
}
--
2.17.1
- [PATCH v3 00/13] Add Thread Sanitizer support to QEMU, Robert Foley, 2020/06/09
- [PATCH v3 01/13] configure: add --enable-tsan flag + fiber annotations for coroutine-ucontext, Robert Foley, 2020/06/09
- [PATCH v3 02/13] cpu: convert queued work to a QSIMPLEQ, Robert Foley, 2020/06/09
- [PATCH v3 03/13] thread: add qemu_spin_destroy, Robert Foley, 2020/06/09
- [PATCH v3 04/13] cputlb: destroy CPUTLB with tlb_destroy, Robert Foley, 2020/06/09
- [PATCH v3 05/13] qht: call qemu_spin_destroy for head buckets, Robert Foley, 2020/06/09
- [PATCH v3 06/13] tcg: call qemu_spin_destroy for tb->jmp_lock, Robert Foley, 2020/06/09
- [PATCH v3 07/13] translate-all: call qemu_spin_destroy for PageDesc,
Robert Foley <=
- [PATCH v3 08/13] thread: add tsan annotations to QemuSpin, Robert Foley, 2020/06/09
- [PATCH v3 09/13] tests/docker: Added docker build support for TSan., Robert Foley, 2020/06/09
- [PATCH v3 10/13] include/qemu: Added tsan.h for annotations., Robert Foley, 2020/06/09
- [PATCH v3 11/13] util: Added tsan annotate for thread name., Robert Foley, 2020/06/09
- [PATCH v3 12/13] docs: Added details on TSan to testing.rst, Robert Foley, 2020/06/09
- [PATCH v3 13/13] tests: Disable select tests under TSan, which hit TSan issue., Robert Foley, 2020/06/09
- Re: [PATCH v3 00/13] Add Thread Sanitizer support to QEMU, Alex Bennée, 2020/06/10