[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH RESEND v3 52/58] microbit: Eliminate two local variables in m
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH RESEND v3 52/58] microbit: Eliminate two local variables in microbit_init() |
Date: |
Wed, 10 Jun 2020 09:54:58 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
On 6/10/20 7:32 AM, Markus Armbruster wrote:
> Suggested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> hw/arm/microbit.c | 14 ++++++--------
> 1 file changed, 6 insertions(+), 8 deletions(-)
>
> diff --git a/hw/arm/microbit.c b/hw/arm/microbit.c
> index d20ebd3aad..8fe42c9d6a 100644
> --- a/hw/arm/microbit.c
> +++ b/hw/arm/microbit.c
> @@ -36,15 +36,13 @@ static void microbit_init(MachineState *machine)
> MicrobitMachineState *s = MICROBIT_MACHINE(machine);
> MemoryRegion *system_memory = get_system_memory();
> MemoryRegion *mr;
> - Object *soc = OBJECT(&s->nrf51);
> - Object *i2c = OBJECT(&s->i2c);
Thanks for this new patch.
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
- [PATCH RESEND v3 54/58] qdev: Make qdev_realize() support bus-less devices, (continued)
- [PATCH RESEND v3 54/58] qdev: Make qdev_realize() support bus-less devices, Markus Armbruster, 2020/06/10
- [PATCH RESEND v3 11/58] qdev: Convert uses of qdev_set_parent_bus() with Coccinelle, Markus Armbruster, 2020/06/10
- [PATCH RESEND v3 35/58] qom: Tidy up a few object_initialize_child() calls, Markus Armbruster, 2020/06/10
- [PATCH RESEND v3 38/58] macio: Eliminate macio_init_child_obj(), Markus Armbruster, 2020/06/10
- [PATCH RESEND v3 34/58] auxbus: Eliminate aux_create_slave(), Markus Armbruster, 2020/06/10
- [PATCH RESEND v3 31/58] auxbus: Rename aux_init_bus() to aux_bus_init(), Markus Armbruster, 2020/06/10
- [PATCH RESEND v3 23/58] ssi: Convert uses of ssi_create_slave_no_init() with Coccinelle, Markus Armbruster, 2020/06/10
- [PATCH RESEND v3 04/58] qdev: New qdev_new(), qdev_realize(), etc., Markus Armbruster, 2020/06/10
- [PATCH RESEND v3 52/58] microbit: Eliminate two local variables in microbit_init(), Markus Armbruster, 2020/06/10
- Re: [PATCH RESEND v3 52/58] microbit: Eliminate two local variables in microbit_init(),
Philippe Mathieu-Daudé <=
- [PATCH RESEND v3 58/58] MAINTAINERS: Make section QOM cover hw/core/*bus.c as well, Markus Armbruster, 2020/06/10
- [PATCH RESEND v3 57/58] qdev: qdev_init_nofail() is now unused, drop, Markus Armbruster, 2020/06/10
- [PATCH RESEND v3 36/58] qom: Less verbose object_initialize_child(), Markus Armbruster, 2020/06/10
- [PATCH RESEND v3 27/58] usb: Convert uses of usb_create(), Markus Armbruster, 2020/06/10
- [PATCH RESEND v3 16/58] pci: Convert uses of pci_create() etc. manually, Markus Armbruster, 2020/06/10
- [PATCH RESEND v3 55/58] qdev: Use qdev_realize() in qdev_device_add(), Markus Armbruster, 2020/06/10
- [PATCH RESEND v3 47/58] sysbus: Convert qdev_set_parent_bus() use with Coccinelle, part 1, Markus Armbruster, 2020/06/10
- [PATCH RESEND v3 53/58] s390x/event-facility: Simplify creation of SCLP event devices, Markus Armbruster, 2020/06/10
- [PATCH RESEND v3 49/58] sysbus: Convert qdev_set_parent_bus() use with Coccinelle, part 3, Markus Armbruster, 2020/06/10
- [PATCH RESEND v3 56/58] qdev: Convert bus-less devices to qdev_realize() with Coccinelle, Markus Armbruster, 2020/06/10