[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 08/24] mac_via: Fix to realize "mos6522-q800-via*" devices
From: |
Laurent Vivier |
Subject: |
Re: [PATCH v3 08/24] mac_via: Fix to realize "mos6522-q800-via*" devices |
Date: |
Wed, 10 Jun 2020 17:46:46 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 |
Le 09/06/2020 à 14:23, Markus Armbruster a écrit :
> mac_via_realize() creates a "mos6522-q800-via1" and a
> "mos6522-q800-via2" device, but neglects to realize them. Affects
> machine q800.
>
> In theory, a device becomes real only on realize. In practice, the
> transition from unreal to real is a fuzzy one. The work to make a
> device real can be spread between realize methods (fine),
> instance_init methods (wrong), and board code wiring up the device
> (fine as long as it effectively happens on realize). Depending on
> what exactly is done where, a device can work even when we neglect
> to realize it.
>
> These two appear to work. Nevertheless, it's a clear misuse of the
> interface. Even when it works today (more or less by chance), it can
> break tomorrow.
>
> Fix by realizing them right away.
>
> Fixes: 6dca62a0000f95e0b7020aa00d0ca9b2c421f341
> Cc: Laurent Vivier <laurent@vivier.eu>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> ---
> hw/misc/mac_via.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/hw/misc/mac_via.c b/hw/misc/mac_via.c
> index e05623d730..82614c155a 100644
> --- a/hw/misc/mac_via.c
> +++ b/hw/misc/mac_via.c
> @@ -890,6 +890,11 @@ static void mac_via_realize(DeviceState *dev, Error
> **errp)
> object_property_add_alias(OBJECT(dev), "irq[1]", OBJECT(ms),
> SYSBUS_DEVICE_GPIO_IRQ "[0]");
>
> + object_property_set_bool(OBJECT(&m->mos6522_via1), true, "realized",
> + &error_abort);
> + object_property_set_bool(OBJECT(&m->mos6522_via2), true, "realized",
> + &error_abort);
> +
> /* Pass through mos6522 input IRQs */
> qdev_pass_gpios(DEVICE(&m->mos6522_via1), dev, "via1-irq");
> qdev_pass_gpios(DEVICE(&m->mos6522_via2), dev, "via2-irq");
>
Tested-by: Laurent Vivier <laurent@vivier.eu>
Acked-by: Laurent Vivier <laurent@vivier.eu>
- [PATCH v3 00/24] Fixes around device realization, Markus Armbruster, 2020/06/09
- [PATCH v3 01/24] arm/stm32f405: Fix realization of "stm32f2xx-adc" devices, Markus Armbruster, 2020/06/09
- [PATCH v3 08/24] mac_via: Fix to realize "mos6522-q800-via*" devices, Markus Armbruster, 2020/06/09
- Re: [PATCH v3 08/24] mac_via: Fix to realize "mos6522-q800-via*" devices,
Laurent Vivier <=
- [PATCH v3 14/24] macio: Put "macio-nvram" device on the macio bus, Markus Armbruster, 2020/06/09
- [PATCH v3 16/24] ppc/pnv: Put "*-pnv-chip" and "pnv-xive" on the main system bus, Markus Armbruster, 2020/06/09
- [PATCH v3 09/24] macio: Fix to realize "mos6522-cuda" and "mos6522-pmu" devices, Markus Armbruster, 2020/06/09
- [PATCH v3 12/24] MAINTAINERS: Make section PowerNV cover pci-host/pnv* as well, Markus Armbruster, 2020/06/09
- [PATCH v3 02/24] display/xlnx_dp: Fix to realize "i2c-ddc" and "aux-to-i2c-bridge", Markus Armbruster, 2020/06/09
- [PATCH v3 05/24] arm/aspeed: Rework NIC attachment, Markus Armbruster, 2020/06/09
- [PATCH v3 21/24] sparc/leon3: Fix to put grlib,* devices on sysbus, Markus Armbruster, 2020/06/09