[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH V2] virtio-pci: fix queue_enable write
From: |
Stefan Hajnoczi |
Subject: |
Re: [PATCH V2] virtio-pci: fix queue_enable write |
Date: |
Thu, 11 Jun 2020 09:41:26 +0100 |
On Wed, Jun 10, 2020 at 01:43:51PM +0800, Jason Wang wrote:
> Spec said: The driver uses this to selectively prevent the device from
> executing requests from this virtqueue. 1 - enabled; 0 - disabled.
>
> Though write 0 to queue_enable is forbidden by the spec, we should not
> assume that the value is 1.
>
> Fix this by ignore the write value other than 1.
>
> Signed-off-by: Jason Wang <jasowang@redhat.com>
> ---
> Changes from V1:
> - fix typo
> - warn wrong value through virtio_error
> ---
> hw/virtio/virtio-pci.c | 12 ++++++++----
> 1 file changed, 8 insertions(+), 4 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
signature.asc
Description: PGP signature