[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 3/3] spapr: Forbid nested KVM-HV in pre-power9 compat mode
From: |
Laurent Vivier |
Subject: |
Re: [PATCH v2 3/3] spapr: Forbid nested KVM-HV in pre-power9 compat mode |
Date: |
Thu, 11 Jun 2020 11:22:52 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 |
On 11/06/2020 11:10, Greg Kurz wrote:
> Nested KVM-HV only works on POWER9.
>
> Signed-off-by: Greg Kurz <groug@kaod.org>
> ---
> hw/ppc/spapr_caps.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/hw/ppc/spapr_caps.c b/hw/ppc/spapr_caps.c
> index 2cb7ba8f005a..e86a7c350444 100644
> --- a/hw/ppc/spapr_caps.c
> +++ b/hw/ppc/spapr_caps.c
> @@ -409,6 +409,8 @@ static void cap_nested_kvm_hv_apply(SpaprMachineState
> *spapr,
> uint8_t val, Error **errp)
> {
> ERRP_AUTO_PROPAGATE();
> + PowerPCCPU *cpu = POWERPC_CPU(first_cpu);
> +
> if (!val) {
> /* capability disabled by default */
> return;
> @@ -418,6 +420,14 @@ static void cap_nested_kvm_hv_apply(SpaprMachineState
> *spapr,
> error_setg(errp, "No Nested KVM-HV support in TCG");
> error_append_hint(errp, "Try appending -machine
> cap-nested-hv=off\n");
> } else if (kvm_enabled()) {
> + if (!ppc_check_compat(cpu, CPU_POWERPC_LOGICAL_3_00, 0,
> + spapr->max_compat_pvr)) {
> + error_setg(errp, "Nested KVM-HV only supported on POWER9");
> + error_append_hint(errp,
> + "Try appending -machine
> max-cpu-compat=power9\n");
> + return;
> + }
> +
> if (!kvmppc_has_cap_nested_kvm_hv()) {
> error_setg(errp,
> "KVM implementation does not support Nested KVM-HV");
>
>
Reviewed-by: Laurent Vivier <lvivier@redhat.com>
- Re: [PATCH v2 2/3] spapr: Use error_append_hint() in spapr_caps.c, (continued)
- Re: [PATCH v2 2/3] spapr: Use error_append_hint() in spapr_caps.c, Greg Kurz, 2020/06/11
- Re: [PATCH v2 2/3] spapr: Use error_append_hint() in spapr_caps.c, Vladimir Sementsov-Ogievskiy, 2020/06/11
- Re: [PATCH v2 2/3] spapr: Use error_append_hint() in spapr_caps.c, Vladimir Sementsov-Ogievskiy, 2020/06/11
- Re: [PATCH v2 2/3] spapr: Use error_append_hint() in spapr_caps.c, Greg Kurz, 2020/06/11
- Re: [PATCH v2 2/3] spapr: Use error_append_hint() in spapr_caps.c, Vladimir Sementsov-Ogievskiy, 2020/06/11
- Re: [PATCH v2 2/3] spapr: Use error_append_hint() in spapr_caps.c, Vladimir Sementsov-Ogievskiy, 2020/06/11
- Re: [PATCH v2 2/3] spapr: Use error_append_hint() in spapr_caps.c, Vladimir Sementsov-Ogievskiy, 2020/06/11
- Re: [PATCH v2 2/3] spapr: Use error_append_hint() in spapr_caps.c, Greg Kurz, 2020/06/11
- Re: [PATCH v2 2/3] spapr: Use error_append_hint() in spapr_caps.c, Laurent Vivier, 2020/06/11
[PATCH v2 3/3] spapr: Forbid nested KVM-HV in pre-power9 compat mode, Greg Kurz, 2020/06/11
- Re: [PATCH v2 3/3] spapr: Forbid nested KVM-HV in pre-power9 compat mode,
Laurent Vivier <=