Re: [PULL 00/16] SPARC patches for 2020-06-09

[Philippe Mathieu-Daudé]

On 6/11/20 3:35 PM, Aleksandar Markovic wrote:
> чет, 11. јун 2020. у 15:30 Philippe Mathieu-Daudé <f4bug@amsat.org> је
> написао/ла:
>>
>> On 6/9/20 10:55 PM, Mark Cave-Ayland wrote:
>>> On 09/06/2020 08:31, Philippe Mathieu-Daudé wrote:
>>>
>>>> Hi Peter,
>>>>
>>>> These are the latest SPARC patches sent to the list.
>>>>
>>>> This pull request is with authorization of Artyom and Mark:
>>>> - https://www.mail-archive.com/qemu-devel@nongnu.org/msg710154.html
>>>> - https://www.mail-archive.com/qemu-devel@nongnu.org/msg710156.html
>>>>
>>>> Frederic doesn't have his GPG key signed:
>>>> - https://www.mail-archive.com/qemu-devel@nongnu.org/msg706509.html
>>>>
>>>> The following changes since commit 
>>>> 49ee11555262a256afec592dfed7c5902d5eefd2:
>>>>
>>>>   Merge remote-tracking branch 
>>>> 'remotes/vivier2/tags/linux-user-for-5.1-pull-=
>>>> request' into staging (2020-06-08 11:04:57 +0100)
>>>>
>>>> are available in the Git repository at:
>>>>
>>>>   https://gitlab.com/philmd/qemu.git tags/sparc-next-20200609
>>>>
>>>> for you to fetch changes up to 86e8c353f705f14f2f2fd7a6195cefa431aa24d9:
>>>>
>>>>   target/sparc/int32_helper: Extract and use excp_name_str() (2020-06-09 
>>>> 09:2=
>>>> 1:10 +0200)
>>>>
>>>> ----------------------------------------------------------------
>>>> SPARC patches
>>>>
>>>> HW:
>>>> - Use UNIMP device instead of EMPTY_SLOT
>>>> - Make EMPTY_SLOT similar to UNIMP device
>>>> - Map UART devices unconditionally
>>>> - Pair of fixes for AHB PnP
>>>> - Add trace events to AHB PnP
>>>>
>>>> TCG:
>>>> - Improve exception logging
>>>>
>>>> CI:
>>>> - https://gitlab.com/philmd/qemu/-/pipelines/154231191
>>>> - https://travis-ci.org/github/philmd/qemu/builds/696321130
>>>>
>>>> ----------------------------------------------------------------
>>>>
>>>> Philippe Mathieu-Daud=C3=A9 (16):
>>>>   hw/sparc/sun4m: Use UnimplementedDevice for I/O devices
>>>>   hw/misc/empty_slot: Lower address space priority
>>>>   hw/misc/empty_slot: Convert 'size' field as qdev property
>>>>   hw/misc/empty_slot: Add a 'name' qdev property
>>>>   hw/misc/empty_slot: Convert debug printf() to trace event
>>>>   hw/misc/empty_slot: Move the 'hw/misc' and cover in MAINTAINERS
>>>>   hw/misc/empty_slot: Name the slots when created
>>>>   hw/sparc/leon3: Map the UART device unconditionally
>>>>   hw/sparc64/niagara: Map the UART device unconditionally
>>>>   hw/sparc64/niagara: Remove duplicated NIAGARA_UART_BASE definition
>>>>   hw/misc/grlib_ahb_apb_pnp: Avoid crash when writing to AHB PnP
>>>>     registers
>>>>   hw/misc/grlib_ahb_apb_pnp: Fix AHB PnP 8-bit accesses
>>>>   hw/misc/grlib_ahb_apb_pnp: Add trace events on read accesses
>>>>   hw/timer/grlib_gptimer: Display frequency in decimal
>>>>   target/sparc/int32_helper: Remove DEBUG_PCALL definition
>>>>   target/sparc/int32_helper: Extract and use excp_name_str()
>>>>
>>>>  include/hw/empty_slot.h        |  9 -------
>>>>  include/hw/misc/empty_slot.h   | 19 ++++++++++++++
>>>>  hw/mips/malta.c                |  4 +--
>>>>  hw/{core =3D> misc}/empty_slot.c | 47 +++++++++++++++++++---------------
>>>>  hw/misc/grlib_ahb_apb_pnp.c    | 24 +++++++++++++++--
>>>>  hw/sparc/leon3.c               | 18 ++++++-------
>>>>  hw/sparc/sun4m.c               | 23 +++++++++++------
>>>>  hw/sparc64/niagara.c           |  7 ++---
>>>>  target/sparc/int32_helper.c    | 23 +++++++++--------
>>>>  MAINTAINERS                    |  7 +++++
>>>>  hw/core/Makefile.objs          |  1 -
>>>>  hw/misc/Makefile.objs          |  1 +
>>>>  hw/misc/trace-events           |  8 ++++++
>>>>  hw/sparc/Kconfig               |  1 +
>>>>  hw/timer/trace-events          |  2 +-
>>>>  15 files changed, 124 insertions(+), 70 deletions(-)
>>>>  delete mode 100644 include/hw/empty_slot.h
>>>>  create mode 100644 include/hw/misc/empty_slot.h
>>>>  rename hw/{core =3D> misc}/empty_slot.c (66%)
>>>>
>>>> --=20
>>>> 2.21.3
>>>
>>> Philippe, thanks so much for handling this - things are really busy here at 
>>> the
>>> moment, so the help is greatly appreciated :)
>>
>> I know you were busy, and the patches are just cleanups, so no problem.
>>
> 
> I guess it is just a matter of time Philippe would ask for SPARC
> maintainership. Mark, would you perhaps accept Philippe as a
> co-maintainer?

Don't worry Aleksandar, Mark and Artyom are experts and manage the
SPARC codebase very well. I don't want to overstep, I simply
wanted to give some help while they are busy.

Actually the core content here are the patches related to the
empty_slot device. The discussion started with Artyom in October
2018:
https://www.mail-archive.com/qemu-devel@nongnu.org/msg564065.html

Since Artyom acked the patches, I pinged few times, Mark and him
were busy, I simply asked them and they agree, but I am not
interested in maintainance, neither I have the SPARC knowledge.

Regards,

Phil.

> 
> Yours,
> Aleksandar
> 
>> Before sending, I tested with all the images I could grab from
>> https://wiki.qemu.org/Documentation/Platforms/SPARC
>> and
>> https://www.qemu.org/docs/master/system/target-sparc64.html
>>
>> I might add more acceptance tests later to automate that.
>>
>> Regards,
>>
>> Phil.
>