Re: [PATCH] tests: disassemble-asm.sh: generate AML in readable format

[no-reply]

Patchew URL: 20200611165112.30979-1-mst@redhat.com/">https://patchew.org/QEMU/20200611165112.30979-1-mst@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20200611165112.30979-1-mst@redhat.com
Subject: [PATCH] tests: disassemble-asm.sh: generate AML in readable format
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
96571e6 tests: disassemble-asm.sh: generate AML in readable format

=== OUTPUT BEGIN ===
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#16: 
new file mode 100755

WARNING: line over 80 characters
#30: FILE: tests/data/acpi/disassemle-aml.sh:10:
+        echo "Usage: ./tests/data/acpi/disassemle-aml.sh [-o 
<output-directory>]"

ERROR: trailing whitespace
#33: FILE: tests/data/acpi/disassemle-aml.sh:13:
+    $

ERROR: trailing whitespace
#70: FILE: tests/data/acpi/disassemle-aml.sh:50:
+        iasl -d -p ${asl} ${extra} ${aml} $

total: 2 errors, 2 warnings, 52 lines checked

Commit 96571e631bfb (tests: disassemble-asm.sh: generate AML in readable 
format) has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20200611165112.30979-1-mst@redhat.com/testing.checkpatch/?type=message">http://patchew.org/logs/20200611165112.30979-1-mst@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com