[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL v2 19/58] tests: tpm-emu: Remove assert on TPM2_ST_NO_SESSIONS
From: |
Michael S. Tsirkin |
Subject: |
[PULL v2 19/58] tests: tpm-emu: Remove assert on TPM2_ST_NO_SESSIONS |
Date: |
Fri, 12 Jun 2020 10:51:44 -0400 |
From: Eric Auger <eric.auger@redhat.com>
bios-tables-test executes SeaBIOS. Indeed FW is needed to
fetch tables from QEMU and put them into the guest RAM. Also
the FW patches cross table pointers. At some point, SeaBIOS
ends up calling the TPM2_CC_HierarchyControl command with
TPM2_ST_SESSIONS tag, most probably steming from
tpm_set_failure/tpm20_hierarchycontrol SeaBIOS call path.
This causes an assert() in the qtest tpm emulation code.
As the goal here is not to boot SeaBIOS completely but just
let it grab the ACPI tables and consolidate them, let's just
remove the assert().
Signed-off-by: Eric Auger <eric.auger@redhat.com>
Message-Id: <20200609125409.24179-4-eric.auger@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
tests/qtest/tpm-emu.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/tests/qtest/tpm-emu.c b/tests/qtest/tpm-emu.c
index c43ac4aef8..298d0eec74 100644
--- a/tests/qtest/tpm-emu.c
+++ b/tests/qtest/tpm-emu.c
@@ -49,7 +49,6 @@ static void *tpm_emu_tpm_thread(void *data)
s->tpm_msg->tag = be16_to_cpu(s->tpm_msg->tag);
s->tpm_msg->len = be32_to_cpu(s->tpm_msg->len);
g_assert_cmpint(s->tpm_msg->len, >=, minhlen);
- g_assert_cmpint(s->tpm_msg->tag, ==, TPM2_ST_NO_SESSIONS);
s->tpm_msg = g_realloc(s->tpm_msg, s->tpm_msg->len);
qio_channel_read(ioc, (char *)&s->tpm_msg->code,
--
MST
- [PULL v2 07/58] acpi: rtc: use a single crs range, (continued)
- [PULL v2 07/58] acpi: rtc: use a single crs range, Michael S. Tsirkin, 2020/06/12
- [PULL v2 06/58] acpi: move aml builder code for rtc device, Michael S. Tsirkin, 2020/06/12
- [PULL v2 08/58] acpi: serial: don't use _STA method, Michael S. Tsirkin, 2020/06/12
- [PULL v2 10/58] acpi: parallel: don't use _STA method, Michael S. Tsirkin, 2020/06/12
- [PULL v2 09/58] acpi: move aml builder code for serial device, Michael S. Tsirkin, 2020/06/12
- [PULL v2 11/58] acpi: move aml builder code for parallel device, Michael S. Tsirkin, 2020/06/12
- [PULL v2 13/58] acpi: tpm: Do not build TCPA table for TPM 2, Michael S. Tsirkin, 2020/06/12
- [PULL v2 15/58] acpi: Move build_tpm2() in the generic part, Michael S. Tsirkin, 2020/06/12
- [PULL v2 16/58] arm/acpi: TPM2 ACPI table support, Michael S. Tsirkin, 2020/06/12
- [PULL v2 12/58] tests/acpi: update DSDT expected files, Michael S. Tsirkin, 2020/06/12
- [PULL v2 19/58] tests: tpm-emu: Remove assert on TPM2_ST_NO_SESSIONS,
Michael S. Tsirkin <=
- [PULL v2 21/58] bios-tables-test: Generate reference tables for Q35/TPM-TIS, Michael S. Tsirkin, 2020/06/12
- [PULL v2 20/58] bios-tables-test: Add Q35/TPM-TIS test, Michael S. Tsirkin, 2020/06/12
[PULL v2 24/58] virtio-balloon: unref the iothread when unrealizing, Michael S. Tsirkin, 2020/06/12
[PULL v2 22/58] virtio-balloon: fix free page hinting without an iothread, Michael S. Tsirkin, 2020/06/12
[PULL v2 23/58] virtio-balloon: fix free page hinting check on unrealize, Michael S. Tsirkin, 2020/06/12
[PULL v2 27/58] MAINTAINERS: Fix the classification of bios-tables-test-allowed-diff.h, Michael S. Tsirkin, 2020/06/12