[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL v2 32/58] hw/pci/pci_bridge: Use the IEC binary prefix definitions
From: |
Michael S. Tsirkin |
Subject: |
[PULL v2 32/58] hw/pci/pci_bridge: Use the IEC binary prefix definitions |
Date: |
Fri, 12 Jun 2020 10:52:13 -0400 |
From: Philippe Mathieu-Daudé <f4bug@amsat.org>
IEC binary prefixes ease code review: the unit is explicit.
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20200601142930.29408-5-f4bug@amsat.org>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
---
hw/pci/pci_bridge.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/pci/pci_bridge.c b/hw/pci/pci_bridge.c
index 3ba3203f72..3789c17edc 100644
--- a/hw/pci/pci_bridge.c
+++ b/hw/pci/pci_bridge.c
@@ -423,14 +423,14 @@ int pci_bridge_qemu_reserve_cap_init(PCIDevice *dev, int
cap_offset,
}
if (res_reserve.mem_non_pref != (uint64_t)-1 &&
- res_reserve.mem_non_pref >= (1ULL << 32)) {
+ res_reserve.mem_non_pref >= 4 * GiB) {
error_setg(errp,
"PCI resource reserve cap: mem-reserve must be less than
4G");
return -EINVAL;
}
if (res_reserve.mem_pref_32 != (uint64_t)-1 &&
- res_reserve.mem_pref_32 >= (1ULL << 32)) {
+ res_reserve.mem_pref_32 >= 4 * GiB) {
error_setg(errp,
"PCI resource reserve cap: pref32-reserve must be less
than 4G");
return -EINVAL;
--
MST
- [PULL v2 54/58] acpi: fadt: add hw-reduced sleep register support, (continued)
- [PULL v2 54/58] acpi: fadt: add hw-reduced sleep register support, Michael S. Tsirkin, 2020/06/12
- [PULL v2 57/58] pci: Display PCI IRQ pin in "info pci", Michael S. Tsirkin, 2020/06/12
- [PULL v2 56/58] Fix parameter type in vhost migration log path, Michael S. Tsirkin, 2020/06/12
- [PULL v2 31/58] hw/pci/pci_bridge: Correct pci_bridge_io memory region size, Michael S. Tsirkin, 2020/06/12
- [PULL v2 05/58] qtest: allow DSDT acpi table changes, Michael S. Tsirkin, 2020/06/12
- [PULL v2 04/58] tests/acpi: update expected SRAT files, Michael S. Tsirkin, 2020/06/12
- [PULL v2 02/58] diffs-allowed: add the SRAT AML to diffs-allowed, Michael S. Tsirkin, 2020/06/12
- [PULL v2 18/58] tests/acpi: Add void tables for Q35/TPM-TIS bios-tables-test, Michael S. Tsirkin, 2020/06/12
- [PULL v2 25/58] virtio-balloon: Implement support for page poison reporting feature, Michael S. Tsirkin, 2020/06/12
- [PULL v2 14/58] acpi: Convert build_tpm2() to build_append* API, Michael S. Tsirkin, 2020/06/12
- [PULL v2 32/58] hw/pci/pci_bridge: Use the IEC binary prefix definitions,
Michael S. Tsirkin <=
- [PULL v2 17/58] test/tpm-emu: include sockets and channel headers in tpm-emu header, Michael S. Tsirkin, 2020/06/12
- [PULL v2 58/58] virtio-pci: fix queue_enable write, Michael S. Tsirkin, 2020/06/12
- [PULL v2 49/58] virtio: add vhost-user-vsock base device, Michael S. Tsirkin, 2020/06/12
- [PULL v2 30/58] hw/pci-host/prep: Correct RAVEN bus bridge memory region size, Michael S. Tsirkin, 2020/06/12
- [PULL v2 50/58] virtio: add vhost-user-vsock-pci device, Michael S. Tsirkin, 2020/06/12
- [PULL v2 48/58] vhost-vsock: add vhost-vsock-common abstraction, Michael S. Tsirkin, 2020/06/12
- Re: [PULL v2 00/58] virtio, acpi, pci: features, fixes, cleanups, tests, no-reply, 2020/06/12
- Re: [PULL v2 00/58] virtio, acpi, pci: features, fixes, cleanups, tests, Peter Maydell, 2020/06/12
- Re: [PULL v2 00/58] virtio, acpi, pci: features, fixes, cleanups, tests, Auger Eric, 2020/06/16