[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 4/6] audio/jack: do not remove ports when finishing
From: |
Geoffrey McRae |
Subject: |
[PATCH 4/6] audio/jack: do not remove ports when finishing |
Date: |
Sat, 13 Jun 2020 14:05:16 +1000 |
This fixes a hang when there is a communications issue with the JACK
server. Simply closing the connection is enough to completely clean up
and as such we do not need to remove the ports first. As JACK uses a
socket based protocol that relies on the `select` call, if there is a
communication breakdown with the server the client library waits
forever for a response to the unregister request.
Signed-off-by: Geoffrey McRae <geoff@hostfission.com>
---
audio/jackaudio.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/audio/jackaudio.c b/audio/jackaudio.c
index 58c7344497..249cbd3265 100644
--- a/audio/jackaudio.c
+++ b/audio/jackaudio.c
@@ -548,9 +548,6 @@ static void qjack_client_fini(QJackClient *c)
{
switch (c->state) {
case QJACK_STATE_RUNNING:
- for (int i = 0; i < c->nchannels; ++i) {
- jack_port_unregister(c->client, c->port[i]);
- }
jack_deactivate(c->client);
/* fallthrough */
--
2.20.1
- [PATCH 0/6] audio/jack: fixes to overall jack behaviour, Geoffrey McRae, 2020/06/11
- [PATCH 0/6] audio/jack: fixes to overall jack behaviour, Geoffrey McRae, 2020/06/14
- [PATCH 5/6] audio/jack: honour the enable state of the audio device, Geoffrey McRae, 2020/06/14
- [PATCH 2/6] audio/jack: remove unused stopped state, Geoffrey McRae, 2020/06/14
- [PATCH 4/6] audio/jack: do not remove ports when finishing,
Geoffrey McRae <=
- [PATCH 1/6] audio/jack: fix invalid minimum buffer size check, Geoffrey McRae, 2020/06/14
- [PATCH 6/6] audio/jack: simplify the re-init code path, Geoffrey McRae, 2020/06/14
- [PATCH 3/6] audio/jack: remove invalid set of input support bool, Geoffrey McRae, 2020/06/14
- Re: [PATCH 0/6] audio/jack: fixes to overall jack behaviour, no-reply, 2020/06/14