Re: [PATCH v8 3/5] softmmu/vl: Allow -fw_cfg 'gen_id' option to use the 'etc/' namespace

[Laszlo Ersek]

On 06/09/20 19:07, Philippe Mathieu-Daudé wrote:
> Names of user-provided fw_cfg items are supposed to start
> with "opt/". However FW_CFG_DATA_GENERATOR items are generated
> by QEMU, so allow the "etc/" namespace in this specific case.
> 
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> v8: addressed Laszlo's comments
> - reword commit description
> - invert nonempty_str() condition
> - new comment in docs/specs/fw_cfg.txt
> ---
>  docs/specs/fw_cfg.txt | 4 ++++
>  softmmu/vl.c          | 8 +++++++-
>  2 files changed, 11 insertions(+), 1 deletion(-)

looks good, thanks!