[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 2/2] qemu-options.hx: Document hmat-lb and hmat-cache orde
From: |
Markus Armbruster |
Subject: |
Re: [PATCH v2 2/2] qemu-options.hx: Document hmat-lb and hmat-cache order |
Date: |
Mon, 15 Jun 2020 10:02:26 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Michal Privoznik <mprivozn@redhat.com> writes:
> To simplify internal implementation the hmat-cache parsing code
> expects hmat-lb to be already parsed. This means, that hmat-lb
> arguments must come before hmat-cache. Document this restriction
> so that management applications can follow it.
>
> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
> ---
> qemu-options.hx | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/qemu-options.hx b/qemu-options.hx
> index b1a399079a..3fe9e6d6a0 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -319,6 +319,9 @@ SRST
> 'none/direct(direct-mapped)/complex(complex cache indexing)'. policy
> is the write policy. line is the cache Line size in bytes.
>
> + Please note, that due to internal implementation, '\ ``hmat-cache``\ '
> + must be configured only after '\ ``hmat-lb``\ ' option.
> +
> For example, the following options describe 2 NUMA nodes. Node 0 has
> 2 cpus and a ram, node 1 has only a ram. The processors in node 0
> access memory in node 0 with access-latency 5 nanoseconds,
What happens when we do it wrong?
Can we catch doing it wrong somehow? I figure that would be much better
than merely documenting it.