[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] Makefile: Compute libraries for libqemuutil.a and libvhost-user.
From: |
Christophe de Dinechin |
Subject: |
[PATCH] Makefile: Compute libraries for libqemuutil.a and libvhost-user.a |
Date: |
Tue, 16 Jun 2020 18:18:14 +0200 |
In util/Makefile.objs, there is a setting for dbus.o-libs.
Trying to copy-paste that to add a library for module.o that was was
not otherwise linked yields link errors on a number of binaries,
e.g. qemu-ga, with unsatisfied symbols in libqemuutil.a(module.o).
The reason is that library dependencies are not propagated to the .a
files automatically.
Adding a call to extract-libs to get the libraries for the two .a
files that are used elsewhere.
Signed-off-by: Christophe de Dinechin <dinechin@redhat.com>
---
Makefile | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Makefile b/Makefile
index 2e93068894..5fb0c78a0b 100644
--- a/Makefile
+++ b/Makefile
@@ -598,6 +598,8 @@ Makefile: $(version-obj-y)
######################################################################
# Build libraries
+libqemuutil.a-libs += $(call extract-libs, $(util-obj-y) $(trace-obj-y)
$(stub-obj-y))
+libvhost-user.a-libs += $(call extract-libs, $(libvhost-user-obj-y)
$(util-obj-y) $(stub-obj-y))
libqemuutil.a: $(util-obj-y) $(trace-obj-y) $(stub-obj-y)
libvhost-user.a: $(libvhost-user-obj-y) $(util-obj-y) $(stub-obj-y)
--
2.26.2
- [PATCH] Makefile: Compute libraries for libqemuutil.a and libvhost-user.a,
Christophe de Dinechin <=