[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 2/6] pci-host: add pcie-msi read method
From: |
P J P |
Subject: |
[PATCH 2/6] pci-host: add pcie-msi read method |
Date: |
Wed, 17 Jun 2020 11:09:29 +0530 |
From: Prasad J Pandit <pjp@fedoraproject.org>
Add pcie-msi mmio read method to avoid NULL pointer dereference
issue.
Reported-by: Lei Sun <slei.casper@gmail.com>
Signed-off-by: Prasad J Pandit <pjp@fedoraproject.org>
---
hw/pci-host/designware.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/hw/pci-host/designware.c b/hw/pci-host/designware.c
index dd245516dd..c34c366f36 100644
--- a/hw/pci-host/designware.c
+++ b/hw/pci-host/designware.c
@@ -21,6 +21,7 @@
#include "qemu/osdep.h"
#include "qapi/error.h"
#include "qemu/module.h"
+#include "qemu/log.h"
#include "hw/pci/msi.h"
#include "hw/pci/pci_bridge.h"
#include "hw/pci/pci_host.h"
@@ -63,6 +64,13 @@ designware_pcie_root_to_host(DesignwarePCIERoot *root)
return DESIGNWARE_PCIE_HOST(bus->parent);
}
+static uint64_t designware_pcie_root_msi_read(void *opaque, hwaddr addr,
+ unsigned size)
+{
+ qemu_log_mask(LOG_UNIMP, "%s not implemented\n", __func__);
+ return 0;
+}
+
static void designware_pcie_root_msi_write(void *opaque, hwaddr addr,
uint64_t val, unsigned len)
{
@@ -77,6 +85,7 @@ static void designware_pcie_root_msi_write(void *opaque,
hwaddr addr,
}
static const MemoryRegionOps designware_pci_host_msi_ops = {
+ .read = designware_pcie_root_msi_read,
.write = designware_pcie_root_msi_write,
.endianness = DEVICE_LITTLE_ENDIAN,
.valid = {
--
2.26.2
- [PATCH 0/6] Add various undefined MMIO r/w functions, P J P, 2020/06/17
- [PATCH 1/6] hw/pci-host: add pci-intack write method, P J P, 2020/06/17
- [PATCH 2/6] pci-host: add pcie-msi read method,
P J P <=
- [PATCH 3/6] vfio: add quirk device write method, P J P, 2020/06/17
- [PATCH 4/6] prep: add ppc-parity write method, P J P, 2020/06/17
- [PATCH 5/6] nvram: add nrf51_soc flash read method, P J P, 2020/06/17
- [PATCH 6/6] spapr_pci: add spapr msi read method, P J P, 2020/06/17
- Re: [PATCH 0/6] Add various undefined MMIO r/w functions, no-reply, 2020/06/17
- Re: [PATCH 0/6] Add various undefined MMIO r/w functions, David Gibson, 2020/06/17