[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PULL V2 00/33] Net patches
From: |
Peter Maydell |
Subject: |
Re: [PULL V2 00/33] Net patches |
Date: |
Fri, 19 Jun 2020 11:45:42 +0100 |
On Fri, 19 Jun 2020 at 04:19, Jason Wang <jasowang@redhat.com> wrote:
>
>
> On 2020/6/18 下午10:05, no-reply@patchew.org wrote:
> > /tmp/qemu-test/src/tests/qht-bench.c:287:29: error: implicit conversion
> > from 'unsigned long' to 'double' changes value from 18446744073709551615 to
> > 18446744073709551616 [-Werror,-Wimplicit-int-float-conversion]
> > *threshold = rate * UINT64_MAX;
> > ~ ^~~~~~~~~~
> > /usr/include/stdint.h:130:23: note: expanded from macro 'UINT64_MAX'
> > ---
> > 18446744073709551615UL
> > ^~~~~~~~~~~~~~~~~~~~~~
>
>
> Cc Emilio.
>
> This looks an issue not related to this pull request.
Yes; it's caused by an upgrade of the compiler version on the
system/container that runs this asan test build for patchew.
This proposed patch would silence the complaint:
20200617201309.1640952-1-richard.henderson@linaro.org/20200617201309.1640952-7-richard.henderson@linaro.org/">https://patchew.org/QEMU/20200617201309.1640952-1-richard.henderson@linaro.org/20200617201309.1640952-7-richard.henderson@linaro.org/
but it is waiting for review and/or discussion of what
the right actual fix to the code would be.
thanks
-- PMM
- [PULL V2 26/33] net/colo-compare.c: Fix deadlock in compare_chr_send, (continued)
- [PULL V2 26/33] net/colo-compare.c: Fix deadlock in compare_chr_send, Jason Wang, 2020/06/18
- [PULL V2 27/33] net/colo-compare.c: Only hexdump packets if tracing is enabled, Jason Wang, 2020/06/18
- [PULL V2 28/33] net/colo-compare.c: Check that colo-compare is active, Jason Wang, 2020/06/18
- [PULL V2 29/33] net/colo-compare.c: Correct ordering in complete and finalize, Jason Wang, 2020/06/18
- [PULL V2 31/33] hw/net/e1000e: Do not abort() on invalid PSRCTL register value, Jason Wang, 2020/06/18
- [PULL V2 32/33] net: Drop the legacy "name" parameter from the -net option, Jason Wang, 2020/06/18
- [PULL V2 33/33] net: Drop the NetLegacy structure, always use Netdev instead, Jason Wang, 2020/06/18
- [PULL V2 30/33] colo-compare: Fix memory leak in packet_enqueue(), Jason Wang, 2020/06/18
- Re: [PULL V2 00/33] Net patches, no-reply, 2020/06/18
- Re: [PULL V2 00/33] Net patches, Peter Maydell, 2020/06/19