qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v1] memory: assert MemoryRegionOps callbacks are defined


From: Paolo Bonzini
Subject: Re: [PATCH v1] memory: assert MemoryRegionOps callbacks are defined
Date: Fri, 19 Jun 2020 13:00:19 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0

On 19/06/20 12:48, P J P wrote:
> | - hw/nvram/nrf51_nvm.c's flash_ops which is fixed if ROMD regions are
> | changed not to require a read callback.
> | 
> | - designware_pci_host_msi_ops which is broken and should have a dummy
> | read callback.
> 
> 
> ie. we add these routines along with the assertions here, right?
> 
> Earlier patch series adds routines for nrf51_nvm and designware. I'll add 
> r/w routines for tz_ppc_dummy_ops.

In this case, please add "Based-on: <MESSAGEID>" to the patch so that
it's clear to the reviewer that there are dependencies.

Thanks!

Paolo




reply via email to

[Prev in Thread] Current Thread [Next in Thread]