Re: [PATCH v5 0/6] Add strace support for printing arguments of selected syscalls

[no-reply]

Patchew URL: 
20200619123331.17387-1-filip.bozuta@syrmia.com/">https://patchew.org/QEMU/20200619123331.17387-1-filip.bozuta@syrmia.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PATCH v5 0/6] Add strace support for printing arguments of selected 
syscalls
Type: series
Message-id: 20200619123331.17387-1-filip.bozuta@syrmia.com

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
52aa860 linux-user: Add strace support for printing arguments of fallocate()
4c19db2 linux-user: Add strace support for printing arguments of 
chown()/lchown()
86be983 linux-user: Add strace support for printing arguments of lseek()
1c0cb78 linux-user: Add strace support for printing argument of syscalls used 
for extended attributes
91ddfc1 linux-user: Add strace support for a group of syscalls
03a0933 linux-user: Extend strace support to enable argument printing after 
syscall execution

=== OUTPUT BEGIN ===
1/6 Checking commit 03a0933cf661 (linux-user: Extend strace support to enable 
argument printing after syscall execution)
2/6 Checking commit 91ddfc1e85a3 (linux-user: Add strace support for a group of 
syscalls)
3/6 Checking commit 1c0cb78849ef (linux-user: Add strace support for printing 
argument of syscalls used for extended attributes)
4/6 Checking commit 86be9834ac89 (linux-user: Add strace support for printing 
arguments of lseek())
5/6 Checking commit 4c19db2dcfc2 (linux-user: Add strace support for printing 
arguments of chown()/lchown())
6/6 Checking commit 52aa8607acaa (linux-user: Add strace support for printing 
arguments of fallocate())
ERROR: storage class should be at the beginning of the declaration
#70: FILE: linux-user/strace.c:1138:
+UNUSED static struct flags falloc_flags[] = {

total: 1 errors, 0 warnings, 104 lines checked

Patch 6/6 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20200619123331.17387-1-filip.bozuta@syrmia.com/testing.checkpatch/?type=message">http://patchew.org/logs/20200619123331.17387-1-filip.bozuta@syrmia.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com