Re: [PULL 0/7] Audio 20200619 patches

[no-reply]

Patchew URL: 20200619131741.10857-1-kraxel@redhat.com/">https://patchew.org/QEMU/20200619131741.10857-1-kraxel@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PULL 0/7] Audio 20200619 patches
Type: series
Message-id: 20200619131741.10857-1-kraxel@redhat.com

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/20200619123331.17387-1-filip.bozuta@syrmia.com -> 
patchew/20200619123331.17387-1-filip.bozuta@syrmia.com
Switched to a new branch 'test'
426e843 hw/audio/gus: Fix registers 32-bit access
ffad943 audio/jack: simplify the re-init code path
8ec48ef audio/jack: honour the enable state of the audio device
f4073f5 audio/jack: do not remove ports when finishing
fc314a6 audio/jack: remove invalid set of input support bool
69c5f3f audio/jack: remove unused stopped state
f6586ef audio/jack: fix invalid minimum buffer size check

=== OUTPUT BEGIN ===
1/7 Checking commit f6586ef90b7e (audio/jack: fix invalid minimum buffer size 
check)
2/7 Checking commit 69c5f3fe0a17 (audio/jack: remove unused stopped state)
3/7 Checking commit fc314a6b8aa3 (audio/jack: remove invalid set of input 
support bool)
4/7 Checking commit f4073f5cb054 (audio/jack: do not remove ports when 
finishing)
5/7 Checking commit 8ec48efb1b21 (audio/jack: honour the enable state of the 
audio device)
ERROR: space required before the open parenthesis '('
#44: FILE: audio/jackaudio.c:277:
+            for(int i = 0; i < c->nchannels; ++i) {

total: 1 errors, 0 warnings, 91 lines checked

Patch 5/7 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

6/7 Checking commit ffad943bccbc (audio/jack: simplify the re-init code path)
7/7 Checking commit 426e843e768c (hw/audio/gus: Fix registers 32-bit access)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20200619131741.10857-1-kraxel@redhat.com/testing.checkpatch/?type=message">http://patchew.org/logs/20200619131741.10857-1-kraxel@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com